Closed
Bug 971948
Opened 10 years ago
Closed 10 years ago
Bookmark toolbar items icon is broken in the palette
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
VERIFIED
FIXED
Firefox 30
People
(Reporter: u428464, Assigned: jaws)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:P5])
Attachments
(2 files)
15.44 KB,
image/png
|
Details | |
1.88 KB,
patch
|
Gijs
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
It just looks completely distorted.
Blocks: australis-cust
Summary: Bookmark toolbar item's icon is broken in the palette → Bookmark toolbar items icon is broken in the palette
Whiteboard: [Australis:P4]
Assignee | ||
Comment 1•10 years ago
|
||
Most likely broken by bug 897496.
Assignee | ||
Updated•10 years ago
|
Whiteboard: [Australis:P4] → [Australis:P5]
Comment 2•10 years ago
|
||
Updated•10 years ago
|
OS: Windows 7 → All
This is resolved at least on Windows.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → WORKSFORME
Assignee | ||
Comment 4•10 years ago
|
||
This is still looking distorted for me on fx-team 363beb46bd10 Win8.1.
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Assignee | ||
Updated•10 years ago
|
Status: REOPENED → NEW
Comment 5•10 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4) > This is still looking distorted for me on fx-team 363beb46bd10 Win8.1. Same on a new profile on Win 7. Seems to be fine on OS X 10.9.
Comment 6•10 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #5) > (In reply to Jared Wein [:jaws] (please needinfo? me) from comment #4) > > This is still looking distorted for me on fx-team 363beb46bd10 Win8.1. > > Same on a new profile on Win 7. Seems to be fine on OS X 10.9. Huh, and of course straight after that I can't reproduce on Win 7 anymore. Something weird is up here. :-\
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Assignee | ||
Comment 7•10 years ago
|
||
The stretching of the icon is no longer present, I think that got fixed recently by removing the overflow:hidden, etc. This patch fixes the positioning of the label in the palette and menu panel.
Attachment #8390801 -
Flags: review?(gijskruitbosch+bugs)
Comment 8•10 years ago
|
||
Comment on attachment 8390801 [details] [diff] [review] Patch Review of attachment 8390801 [details] [diff] [review]: ----------------------------------------------------------------- r=me on the min-height, but I'm confused about the label's margin... ::: browser/themes/shared/customizableui/panelUIOverlay.inc.css @@ +133,5 @@ > > .panelUI-grid .toolbarbutton-1 > .toolbarbutton-text, > .panelUI-grid .toolbarbutton-1 > .toolbarbutton-multiline-text { > text-align: center; > + /* Need to override toolkit theming which sets margin: 0 !important; */ On what OS do we need to override this? I'm having to modify this for the subviewbuttons already (although they might not be toolbarbutton-1, come to think of it), and I'd like to not exacerbate our use of !important too much. :-(
Assignee | ||
Comment 9•10 years ago
|
||
We need 'important' for Linux and Windows, not OSX: http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/toolbarbutton.css#32 http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/toolbarbutton.css#24 http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/toolbarbutton.css#30 Would you rather that I write the following? %ifdef XP_MACOSX margin: 2px 0 0; %else margin: 2px 0 0 !important; %endif
Comment 10•10 years ago
|
||
(In reply to Jared Wein [:jaws] (please needinfo? me) from comment #9) > We need 'important' for Linux and Windows, not OSX: > http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/linux/global/ > toolbarbutton.css#32 > http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/ > toolbarbutton.css#24 > http://mxr.mozilla.org/mozilla-central/source/toolkit/themes/windows/global/ > toolbarbutton.css#30 > > Would you rather that I write the following? > %ifdef XP_MACOSX > margin: 2px 0 0; > %else > margin: 2px 0 0 !important; > %endif Nah, it's ok.
Updated•10 years ago
|
Attachment #8390801 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 11•10 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/95341f53d78f
Whiteboard: [Australis:P5] → [Australis:P5][fixed-in-fx-team]
Comment 12•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/95341f53d78f
Status: ASSIGNED → RESOLVED
Closed: 10 years ago → 10 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:P5][fixed-in-fx-team] → [Australis:P5]
Target Milestone: --- → Firefox 30
Assignee | ||
Comment 13•10 years ago
|
||
Comment on attachment 8390801 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 897496 User impact if declined: label for palette item is out of line with other items Testing completed (on m-c, etc.): locally and m-c Risk to taking this patch (and alternatives if risky): none expected String or IDL/UUID changes made by this patch: none
Attachment #8390801 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
Attachment #8390801 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•10 years ago
|
status-firefox29:
--- → affected
status-firefox30:
--- → fixed
Assignee | ||
Comment 14•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/9f7b62796b0d
Updated•10 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•