972284 - Remove the "→" from networkMenu.totalMS

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Victor Porof [:vporof][:vp]]

It's just noise. We should really remove it.

Comment 1

[Ariel Burone]

Attachment: Bug972284.patch

Attached a patch file to fix the bug. I was unable to submit to phabricator for review

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 9014901 [details] [diff] [review]
Bug972284.patch

Review of attachment 9014901 [details] [diff] [review]:
-----------------------------------------------------------------

I think we also need to update the localisation id as well, so that localisers update this for every language.

Comment 3

[Ariel Burone]

(In reply to Victor Porof [:vporof][:vp] from comment #2)
> Comment on attachment 9014901 [details] [diff] [review]
> Bug972284.patch
> 
> Review of attachment 9014901 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> I think we also need to update the localisation id as well, so that
> localisers update this for every language.

I have no idea what that id is. That's my first time with Firefox code, sorry.
I figured It should be localized, but don't know the procedure to reach to the localizers.

Comment 4

[Victor Porof [:vporof][:vp]]

That's "networkMenu.totalMs", should change it to something like "networkMenu.totalMs2"

Comment 5

[Ariel Burone]

Attachment: 972284.patch

Done, new patch
Tried to install a language pack to see which error this would create but can't override the version check

Comment 6

[Victor Porof [:vporof][:vp]]

Comment on attachment 9014997 [details] [diff] [review]
972284.patch

Review of attachment 9014997 [details] [diff] [review]:
-----------------------------------------------------------------

Don't worry, localisers will pick that up.

Looks good to me. Should push to try first to see if there's any tests that fail, r+ if green.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Nice, thanks!

@Ariel, don't forget to:

1) Mark the old patch as obsolete (Details -> Edit Details -> Check Obsolete checkbox)
2) Set checkin-needed into the Keywords list (use the blue Edit button at the top) if try is green

Try push results here:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=37b80b62257fd261d12f1c28be9803c775710396
(there should be no failures)

Honza

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Try looks good.

@Ariel, the next step is to add `checkin-needed` keyword so sheriffs can land the patch into the m-c (Mozilla Central) repo.

1) Click the Blue Edit Bug button at the top
2) See the Tracking -> Keywords input field
3) Add checkin-needed
4) Click Save Changes (blue button)

Thanks for the help!

Honza

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Adding checkin-needed keyword since Ariel doesn't seem to have enough privileges.

Honza

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9293f334a994
"Remove the "→" from networkMenu.totalMS" r=vporof

Comment 11

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/9293f334a994