972365 - event.preventDefault() is called unexpectedly in apps/system/js/browser_context_menu.js

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bugXXXXXX.patch

Event.preventDefault() should be called only if there is a UI that is shown. Otherwise it prevent a click to fire on the app for any long tap.

I just removed the extra preventDefault() since there is already one in the show() method.

Comment 1

[Kevin Grandon :kgrandon]

Comment on attachment 8375507 [details] [diff] [review]
bugXXXXXX.patch

Review of attachment 8375507 [details] [diff] [review]:
-----------------------------------------------------------------

Is there any way we could add a test for this? Maybe just a unit test? We have:  ./apps/system/test/unit/browser_context_menu_test.js

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Kevin Grandon :kgrandon from comment #1)
> Comment on attachment 8375507 [details] [diff] [review]
> bugXXXXXX.patch
> 
> Review of attachment 8375507 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Is there any way we could add a test for this? Maybe just a unit test? We
> have:  ./apps/system/test/unit/browser_context_menu_test.js

I have a long tail of patches to land that will need some tests. So I will try to provide some since this small line can break a lot of stuffs.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Send something to Travis with some tests.

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/9bb31f0da81f92f0048207ea9cf51628bb1183a5

Merged with tests.