972500 - Rename BaseTest.mLauncherActivityClass to sLauncherActivityClass

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Testing, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It is a static variable, not an instance variable, so it should start with a lower-case s.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

It should also be declared `final`.

Comment 2

[Madushan Nishantha]

I'll take this one :) Just have to rename all the instances on place right?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Indeed! I've assigned the bug to you.

Have you already set up a build environment? If not, you can see the instructions here: https://wiki.mozilla.org/Mobile/Fennec/Android

You'll be modifying code in our Robocop test framework, so you'll need to set that up to test that your changes work: https://wiki.mozilla.org/Auto-tools/Projects/Robocop

When you make changes in the mobile/android/base/tests/ directory, you should only need to recompile Robocop, not the entire browser, for these changes.

While you're developing, I recommend running just a single test because the full robocop test suite takes a long time to run (at least 30 minutes).

If you need any help, you can reply to this bug, or feel free to message me on IRC - my nick is "mcomella" and you can find me in #mobile. If you need IRC setup instructions, see https://wiki.mozilla.org/IRC

Thanks and happy coding! ^_^

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Michael Comella (:mcomella) from comment #3)
> While you're developing, I recommend running just a single test

And make sure it extends BaseTest! :)

Comment 5

[Madushan Nishantha]

(In reply to Michael Comella (:mcomella) from comment #3)

Thanks, I already have a fennec build environment since I've fixed a bug earlier :) 
How can I run a only single test? I haven't had experiences with Robocop before.

Comment 6

[Madushan Nishantha]

Attachment: bug972500-wip.patch

I've changed all the "mLauncherActivityClass" to "sLauncherActivityClass". can someone tell me how to properly test the results. WHen I run make -C {objdir}/build/mobile/robocop/ it builds without problems and installs properly.

Comment 7

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

To run robocop, you specify:

make -C <objdir> mochitest-robocop

To run a single test, you need to set the TEST_PATH environment variable to the name of the test you want to run, e.g.

TEST_PATH=testBookmark make -C <objdir> mochitest-robocop

You can find the list of tests as any file that starts with "test" in mobile/android/base/tests/; make sure the test you run is a sub-class of BaseTest.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8380571 [details] [diff] [review]
bug972500-wip.patch

Review of attachment 8380571 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me. Have you tested the results yet?

Comment 9

[Madushan Nishantha]

Sorry for the hold up with the test. I'm stuck in some studies these days. I'll Test it and post the result as soon as I get a free time.

Comment 10

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Closing as `BaseTest.mLauncherActivityClass` was previously removed (bug # unknown).