Closed Bug 972608 Opened 10 years ago Closed 10 years ago

Update the Feedback charm string

Categories

(Firefox for Metro Graveyard :: Flyouts, defect, P1)

Product:
Firefox for Metro Graveyard
Component:
Flyouts
Platform:
x86_64
Windows 8.1
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
Firefox 30

People

(Reporter: jimm, Assigned: jimm)

References

(
URL
)

Details

(Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff30)

Attachments

(2 files, 2 obsolete files)

example (music app)
48.54 KB, image/png
Details
fix v.3
4.74 KB, patch
sfoster
: review+
Details | Diff | Splinter Review
Attached image example (music app) — 
The current string is "Sumbit Feedback...". The convention however is to use a single word without an ellipsis.
Attached patch fix (obsolete) — — Splinter Review 
for landing on mc only, no uplift.
Assignee: nobody → jmathies
Attachment #8375847 - Flags: review?(sfoster)
Attached patch fix (obsolete) — — Splinter Review 
Making this "Feedback (online)" per the ms spec guidelines.
Attachment #8375847 - Attachment is obsolete: true
Attachment #8375847 - Flags: review?(sfoster)
Attachment #8376172 - Flags: review?(sfoster)
Depends on: 969045
Attached patch fix v.3 — — Splinter Review 
- removed the old hack code
- moved the url into prefs
Attachment #8376172 - Attachment is obsolete: true
Attachment #8376172 - Flags: review?(sfoster)
Attachment #8376179 - Flags: review?(sfoster)
Blocks: metrobacklog
Status: NEW → ASSIGNED
Priority: -- → P1
QA Contact: jbecerra
Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff28
Comment on attachment 8376179 [details] [diff] [review]
fix v.3

Review of attachment 8376179 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks for doing this.
Attachment #8376179 - Flags: review?(sfoster) → review+
https://hg.mozilla.org/mozilla-central/rev/aaa3019c7653
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 30
Whiteboard: p=1 s=it-30c-29a-28b.1 r=ff28 → p=1 s=it-30c-29a-28b.1 r=ff30
Mozilla/5.0 (Windows NT 6.3; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0

Verified as fixed on latest Nightly (Build ID: 20140217030202) using a Windows 8.1 64bit machine and a Microsoft Surface Pro 2 device running 8.1 64bit.

The charm string is now "Feedback (online)".
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: