974224 - Move trychooser hg extension into the new https://hg.mozilla.org/hgcustom/version-control-tools repo

Status: RESOLVED INVALID

(Developer Services :: General, task)

Description

[Ed Morley [:emorley]]

See bug 968958 for context.

I'd like to move in (and combine):
https://bitbucket.org/sfink/trychooser
https://github.com/pbiggar/trychooser

Steve are you ok with this?

Comment 1

[Steve Fink [:sfink] [:s:]]

(In reply to Ed Morley [:edmorley UTC+0] from comment #0)
> See bug 968958 for context.
> 
> I'd like to move in (and combine):
> https://bitbucket.org/sfink/trychooser
> https://github.com/pbiggar/trychooser
> 
> Steve are you ok with this?

I am.

The only thing that kept me from clobbering the pbiggar version already is that the curses stuff doesn't work on Windows, and I have a fallback questionnaire mode but it kinda sucks. I'm not sure if it's worse than pbiggar's questionnaire, but I think it might be. I've always intended to make it a little smarter, but never got around to it. I just refreshed my Windows dev VM, so perhaps I could take another swing at it.

The other thing is that both trychoosers are perpetually out of date with respect to the current set of tests and builds. I don't know if one is currently strictly more up to date than the other or not.

Finally, my trychooser is a little bit of a weird beast in that I ripped the UI code out of the crecord extension, copied it into my extension, and generalized it to work for both crecord and trychooser. (My local version of crecord uses identical code.) It would be sort of nice to share that code in a better way. But I don't think it really matters for what we're doing here.

Comment 2

[Marco Castelluccio [:marco]]

Try selectors have been refactored and are now in-tree.