976108 - The properties positions are moved to the left in the Manifest Editor

Status: VERIFIED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Petruta Horea [:phorea], Desktop QA]

Reproduces on:
latest Aurora (20140224004003)
 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0
latest Nightly (20140224030203)
 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0

Doesn't reproduce on latest Firefox 28 beta 4.

Steps to reproduce:
1. Open about:app-manager page
2. Add a packaged app (download and unzip from https://github.com/mjschranz/webmaker-ffos)
3. Expand a property and move the mouse over the add / remove buttons

Expected results:
The properties are correctly displayed.

Actual results:
The properties values are moved to the left (visual artifact). Expanding another top level object will result in moving it's values to the left while the values for the properties previously expanded will be displayed correctly. Collapsing an object will reproduce the issue again. 

Notes: 
1. The issue also reproduces on Ubuntu 32-bit and Mac OS 10.9
2. The issue is a regression
Regression range:
Last good revision: 3e40f7389d1b (2014-02-02)
First bad revision: 44ba69cacd7e (2014-02-03)
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?romchange=3e40f7389d1b&tochan
ge=44ba69cacd7e

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Reset icon position in manifest editor on focus

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Looks like the regression was from bug 952277.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/fx-team/rev/4a3f182f06c0

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/4a3f182f06c0

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8381731 [details] [diff] [review]
Reset icon position in manifest editor on focus

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 952277
User impact if declined: Focused lines in the manifest editor become indented strangely
Testing completed (on m-c, etc.): m-c
Risk to taking this patch (and alternatives if risky): Low, CSS changes specific to manifest editor
String or IDL/UUID changes made by this patch: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/71755e49f3e8

Comment 7

[Petruta Horea [:phorea], Desktop QA]

Verified as fixed on Firefox 29 beta 2 (20140324101726) and Aurora 30.0a2 (20140324150430) under Mac OS X 10.8.5, Ubuntu 32-bit and Win 7 64-bit.