976299 - Settings Regions That are TranslateX out of view take up an extra layer

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Mason Chang [Inactive] [:mchang]]

Attachment: Layer Tree

See the attached layer. We're using up extra memory and an extra layer because of the sections that are non visible. Optimize this out.

Comment 1

[Mason Chang [Inactive] [:mchang]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16583

Saw that we take an extra layer from the sections listed above in the settings app. Just changing the visibility retains the extra layer. Sometimes gecko optimizes it out, but not all the time. The downside to this patch is that every time we switch a section, we incur a ~8ms reflow on a hamachi. Currently, we only incur this reflow on the first time we go into a sub section. Is this tradeoff ok? Otherwise, do we have to extract all the subpages out to an extra page?

Comment 2

[Mason Chang [Inactive] [:mchang]]

Attachment: Layer Tree w/ Patch

And a profile:

https://people.mozilla.org/~bgirard/cleopatra/#report=9d77c8ca60e11387983095932baf3381aed04115

We still have > 100 ms rasterizes, but not quite as often.

Comment 3

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8380932 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16583

The issue with such a patch is that it basically destroyed all transitions between panels.

Comment 4

[Mason Chang [Inactive] [:mchang]]

Comment on attachment 8380932 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16583

Thanks, reworking.

Comment 5

[Eitan Isaacson [:eeejay]]

I'm curious, wouldn't it be easier to do visibility: hidden? You wouldn't be triggering a reflow, and it works very well with css transitions. Although, it may keep a layer around, I am not sure.

Comment 6

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Eitan Isaacson [:eeejay] from comment #5)
> I'm curious, wouldn't it be easier to do visibility: hidden? You wouldn't be
> triggering a reflow, and it works very well with css transitions. Although,
> it may keep a layer around, I am not sure.

It keeps a layer around.

Comment 7

[Mason Chang [Inactive] [:mchang]]

Attachment: Layer Tree w/ Patch

Comment 8

[Mason Chang [Inactive] [:mchang]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16727

Comment 9

[Mason Chang [Inactive] [:mchang]]

Attachment: https://github.com/mozilla-b2g/gaia/pull/16764

Works while keeping the animations. Can you please check to see if there is some other edge case? Thanks

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 8384214 [details] [review]
https://github.com/mozilla-b2g/gaia/pull/16764

LGTM when trying it :)

Comment 11

[Mason Chang [Inactive] [:mchang]]

Landed in master - 6a566e8ad2b94b8123da1a43a6ee870612b11759