978050 - Use a bright color for the outline of the tab strip in customization mode with certain themes

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Attachment: Hardly visible outlines

With the Windows XP themes »Luna blue (default)« and »Windows Classic«, the outline of the customizable area in the tab strip is hardly visible. It should use white as the color in these cases.

I guess this problem will also arise on Windows 8 when the window color is too dark and possibly even on Windows 7 (I don't have a test setup for the latter).

Comment 1

[:Gijs (he/him)]

Attachment: fix the hovered outline-color for Australis' customize mode's drag indicators for tabsintitlebar menubar/tabstoolbar to be the caption text color,

So this will do the right thing on XP, I'm pretty sure, but on Win7/Win8 we don't know what the window color is so we also can't do much else. However, this patch uses the captiontext color, so once we add support for fixing that, we might get support for win8 for free (or we might need to update to another constant, but either way, it should be less work to fix stuff).

Comment 2

[Matthew N. [:MattN]]

Comment on attachment 8385324 [details] [diff] [review]
fix the hovered outline-color for Australis' customize mode's drag indicators for tabsintitlebar menubar/tabstoolbar to be the caption text color,

Review of attachment 8385324 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with :not([inFullscreen]) on the window

::: browser/themes/windows/browser.css
@@ +54,5 @@
>  #main-window[tabsintitlebar] #main-menubar > menu:not(:-moz-lwtheme):-moz-window-inactive {
>    color: InactiveCaptionText;
>  }
>  
> +#main-window[customize-entered][tabsintitlebar] #toolbar-menubar[customizing-dragovertarget].customization-target::before,

Since LWT don't apply in customization mode, we don't need to special-case that (contrary to what I said in person).

I think we should do :not([inFullscreen]) since the titlebar colour isn't shown behind these toolbars in fullscreen. (See the block "/* Use lighter colors of buttons and text in the titlebar on luna-blue */")

Comment 3

[:Gijs (he/him)]

w/ nit

remote:   https://hg.mozilla.org/integration/fx-team/rev/86ef16e078a3

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/86ef16e078a3

Comment 5

[:Gijs (he/him)]

Comment on attachment 8385324 [details] [diff] [review]
fix the hovered outline-color for Australis' customize mode's drag indicators for tabsintitlebar menubar/tabstoolbar to be the caption text color,

[Approval Request Comment]
Bug caused by (feature/regressing bug #): Australis
User impact if declined: invisible outlines on the tabstoolbar/menubar on certain OS themes, meaning it's harder to figure out how/where to customize
Testing completed (on m-c, etc.): on m-c, locally
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 6

[:Gijs (he/him)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/f948eb47b645


Note for QA: this is effectively not testable because bug 978048 removed the outlines entirely.