98288 - Enable Pause/Resume when downloading via http

Status: VERIFIED FIXED

(SeaMonkey :: Download & File Handling, enhancement)

Description

[sairuh (rarely reading bugmail)]

found using 2001.09.04.xx-comm bits on all platforms. the Pause [and
subsequently, Resume] button doesn't seem to appear when i download via http.

not sure what caused this. punt as needed.

1. click on an http download link --eg,
http://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-macosX-trunk.sit.bin
--if the helper app dialog appears, make sure "save this file to disk" is
selected, then click OK.
2. chose a download location in the resulting file picker dialog, then click OK.
3. look at the download progress dialog that appears.

expected: you should see a Pause button in the download progress dialog.

actual: no Pause button. unable to pause download.

Comment 1

[sairuh (rarely reading bugmail)]

Attachment: shot of dialog lacking Pause button for http download

Comment 2

[sairuh (rarely reading bugmail)]

definitely a regression. would it be possible to fix for 0.9.4?

this is not a problem when i downloaded via ftp, eg,
ftp://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-macosX-trunk.sit.bin

will attach a shot of this, for comparison.

Comment 3

[sairuh (rarely reading bugmail)]

Attachment: shot of ftp download --buttons look fine

Comment 4

[sairuh (rarely reading bugmail)]

spoke with bill and blake --this might be expected behavior.

dang, my memory is really rusty about this, so i'm gonna check the 6.1rtm bits...

Comment 5

[sairuh (rarely reading bugmail)]

6.1rtm shows the same behavior. marking invalid. apologies for the noise.

Comment 6

[sairuh (rarely reading bugmail)]

"nothing to see here"

Comment 7

[benc]

REOPEN:

This isn't really invalid, it should be an RFE.

You can use byteranges + etags and other headers to continue the loading of a
file you did not fully receive.

This might also be a dupe of something already in bugzilla.

Comment 8

[sairuh (rarely reading bugmail)]

okay, i'll make this an rfe...however, methinks this might be taken care of by
ben's proposed download manager? see bug 25995 for details on that.

Comment 9

[benc]

I think what I describe is the the method he plans to use.

Comment 10

[sairuh (rarely reading bugmail)]

spam: over to File Handling. i have not changed the assigned developer [or the
other fields for that matter], so if anyone realizes that a bug should have a
more appropriate owner, go ahead and change it. :)

Comment 11

[Blake Ross]

--> law

Comment 12

[Bill Law]

Changed summary to note this is an RFE (and clarify what it is).

->Futre because I don't think we will have time to do this and I don't believe 
the download manager includes this feature.

Comment 13

[Francisco León]

bug 107552 will resolve resuming in ftp. After that, we could use the ui for 
pausing and resuming.
I really dont know if http resuming is currently possible. If yes, then that 
dependency i just put is wrong and we need another bug for it

Comment 14

[Blake Ross]

It would be nice to get this feature for download manager, which I'm currently 
working on, but not a formal requirement at this time.  Cc'ing bbaetz, who was 
starting work on this before he left, I believe, and Darin.  Darin, should this 
belong to the necko group?

Comment 15

[Bradley Baetz (:bbaetz)]

I have this hacked up for ftp-cross session support - not sure what the bug# 
for that is. It works in heory, but I didn't write a test program before I 
left, so...

Once that is in, getting this working for http would belong to necko, I think. 
The APIs got posted to npm.netlib a couple of months ago, but I didn have to 
modify them a bit.

Comment 16

[Darin Fisher]

yeah, full support for HTTP suspend/resume is going to require significant necko
land work.

Comment 17

[Oliver Klee]

*** Bug 134821 has been marked as a duplicate of this bug. ***

Comment 18

[Matthias Versen [:Matti]]

*** Bug 135956 has been marked as a duplicate of this bug. ***

Comment 19

[gavin long]

*** Bug 150463 has been marked as a duplicate of this bug. ***

Comment 20

[Markus Långström]

*** Bug 153548 has been marked as a duplicate of this bug. ***

Comment 21

[Jo Hermans]

*** Bug 171338 has been marked as a duplicate of this bug. ***

Comment 22

[Max Alekseyev]

I think this bug depends on bug 18004 but not block it. Having no engine for
pausing/resuming http downloads, it is impossible to implement requested feature.
Moreover, it seems reasonable for me to mark this bug simply as duplicate of bug
18004 since they both are long-life RFE's with almost negligible difference.
Do you agree?

Comment 23

[timeless]

.

Comment 24

[Boris Zbarsky [:bzbarsky]]

*** Bug 178318 has been marked as a duplicate of this bug. ***

Comment 25

[Darin Fisher]

bug 176919 should make this easier to implement.

Comment 26

[Simon Paquet [:sipaq]]

*** Bug 217826 has been marked as a duplicate of this bug. ***

Comment 27

[benc]

-> Download manager.

All the dupes are in download manager, and clearly people are not seeing this
open bug in HTTP.

This needs to be tested in download manger when it is fixed, and would depend on
additional support in necko, for which I've created bug 219556.

I've also removed the depends on 107552, because this would not depend on an FTP
fix (as well as still not working even though all the dependencies are fixed.

Comment 28

[Joseph Myers]

I have never seen pause/resume download functions as the default in Netscape or Mozilla. Can 
anyone explain how this is supposed to work?

Is it better to make downloads resumable only from the list which is within the download manager 
widget, or also to make downloads resumable when saving to an existing file, by assuming that 
the person knows what they are doing and is intending to resume a download?

Should a "Resume download..." function be added to the context menus for links or downloads, 
rather than only an option to save the file? If this was done, then it would be then easier to 
integrate downloading and resuming with necko, after prompting the user with a dialogue saying, 
"Locate download file to continue downloading..." after they had clicked on a link to "Resume" 
downloading it.

Comment 29

[Isaac Hwak Han]

*** Bug 231208 has been marked as a duplicate of this bug. ***

Comment 30

[Max Alekseyev]

*** Bug 237156 has been marked as a duplicate of this bug. ***

Comment 31

[Alfonso Martinez]

*** Bug 238996 has been marked as a duplicate of this bug. ***

Comment 32

[Frédéric Buclin]

Should not this bug be closed now? The Pause/Resume button is now available and
working fine when downloading files via HTTP (tested with Mozilla 1.7 RC2 on
Linux). Or I do not understand what you are talking about!?!

Comment 33

[Christian :Biesinger (don't email me, ping me on IRC)]

download manager bugs are a mess. everything after comment 7 disagrees with
comment 0 and the summary. oh well.

Comment 34

[Ian Neal]

This was fixed by the checkin for bug 219556

Comment 35

[Christian :Biesinger (don't email me, ping me on IRC)]

that checkin did not affect anything that users can see... anyway, comment 0 and
the summary are fixed (because of a different bug). marking verified.