98600 - use of NS_ERROR_NO_CONTENT from the URILoader causes an assert

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Christopher Blizzard (:blizzard)]

The use of NS_ERROR_NO_CONTENT() from nsMailtoChannel::AsyncOpen() has caused
problems when loading mailto: urls from the URILoader.  It looks like the
docshell code was patched to handle this error condition but the URI Loader
hasn't been.  Patch to follow.

Comment 1

[Christopher Blizzard (:blizzard)]

Attachment: uriloader patch

Comment 2

[Christopher Blizzard (:blizzard)]

I need review/super-review from you guys since this seems to be your area.  I
need this for X Remote fixes.

Comment 3

[rpotts (gone)]

oops, you're right... 

I think that a better patch would be to combine the check with 
NS_ERROR_DOM_RETVAL_UNDEFINED.  

something like this:

  if (rv == NS_ERROR_DOM_RETVAL_UNDEFINED ||
      rv == NS_ERROR_NO_CONTENT)

rather than adding another if statement

Hopefully, NS_ERROR_DOM_RETVAL_UNDEFINED is going away in favor of 
NS_ERROR_NO_CONTENT.  

Comment 4

[Christopher Blizzard (:blizzard)]

What about the warning after the check?  It's not a warning condition, is it?

Comment 5

[rpotts (gone)]

Yeah... we can lose the NS_WARNING(...).  

Comment 6

[Christopher Blizzard (:blizzard)]

Attachment: patch #2

Comment 7

[Scott MacGregor]

Comment on attachment 48476 [details] [diff] [review]
patch #2

sr=mscott

Comment 8

[Christopher Blizzard (:blizzard)]

Checked in.  Thanks, guys!