986459 - Add the error object to worker's onerror

Status: RESOLVED FIXED

(Core :: DOM: Workers, defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

What is this bug about, exactly?  Which error object should be added to where?  Is this basically like bug 873070 or something else?

Note that the spec says:

    For dedicated workers, if the error is still not handled afterwards,
    the user agent must queue a task to fire a trusted event that uses 
    the ErrorEvent interface, with the name error, that doesn't bubble 
    and is cancelable, with its message, filename, lineno, colno, attributes
    initialised appropriately, and with the error attribute initialised to
    null, at the Worker object associated with the worker.

Are you asking for that "initialised to null" to be changed to something else?  If so, that seems like something you should raise as a spec issue.

Comment 2

[Tom S [:evilpie]]

Yes, I think that was about worker.onerror including the Error object.

Comment 3

[Boris Zbarsky [:bzbarsky]]

OK, how should this work, given that they're different JSRuntimes/threads?  If you do have ideas, please propose them as spec issues.

Comment 4

[Tom S [:evilpie]]

Okay, thinking about this a bit more and reading bug 355430 again: This was actually about onerror in the Worker scope. It seems like the error object parameter there is always null.

Comment 5

[Tom S [:evilpie]]

Attachment: test

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Testcase not using the non-standard Array.map thing

Comment 7

[Boris Zbarsky [:bzbarsky]]

Thanks, that's pretty clear.  The spec does say that inside the worker the .error on the error event should be the right thing.

It looks like Chrome gets this wrong too; I've filed <https://bugs.chromium.org/p/chromium/issues/detail?id=640724>.  WebKit nightly gets it right.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Attachment: The error event in a worker (firing at the worker's global) should have the original exception value in its .error property

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae506f25d5f1
The error event in a worker (firing at the worker's global) should have the original exception value in its .error property.  r=baku

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ae506f25d5f1