9866 - [malloc] memory allocation problems - xpfe

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[chris hofmann]

malloc] memory allocation problems - xpfe

check bug 8227 for more details on what needs to be done to this code

s:/mozilla/xpfe/appshell/src/nsWebShellWindow.cpp
   Deref-error: "menuDelegate", line 728
   Deref-error: "menuDelegate", line 729
   Deref-error: "menuDelegate", line 730
   Deref-error: "menuDelegate", line 731
s:/mozilla/xpfe/components/find/src/nsFindComponent.cpp
   Deref-error: "dialog", line 671
s:/mozilla/xpfe/components/ucth/src/nsUnknownContentTypeHandler.cpp
   Deref-error: "dialog", line 244

Comment 1

[don]

Radha, can you take care of this for M9?  If not, re-assign to Bill for M10.

Comment 2

[Radha on family leave (not reading bugmail)]

I don't quite see a need to fix the menu delegate thing. For other files, the
line number seems a littlle mismatched. Reassigning to Bill, since he knows
better.

Comment 3

[Bill Law]

I've fixed the menuDelegate thing in my tree (it needs fixing because if the
allocation fails, we'll crash dereferencing the pointer).  The problem in
nsFindComponent has gone away (not in most recent report).  There is a false
positive in the report about nsStreamTransfer.cpp but I'll ignore that.

I'll check in my fix and mark this resolved soon.

Comment 4

[Bill Law]

Fix checked in.

Comment 5

[leger]

Mac memory leaks not a big problem anymore.  Browser automation running...looks
good.  Marking Verified.