988073 - Make --enable-debug gecko device builds for B2G

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Gregor Wagner [:gwagner]]

Can we get a device build with debug gecko enabled?
I don't think we need a per-commit build. MC granularity with multiple builds per day would be enough.

It would help a lot if QA has access to debug builds so we can have regression ranges for debug-only assertions.

Comment 1

[Aki Sasaki (not active)]

Would we need this in addition to debug desktop builds or instead of? bug 956451

Comment 2

[Gregor Wagner [:gwagner]]

That's in addition.
Basically QA should be able to flash a phone with a debug-gecko version.
So for device builds we just have to add the --enable-debug flag in the mozconfig.

Comment 3

[Aki Sasaki (not active)]

Do debug emulator builds help here?  e.g. http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/b2g-inbound-emulator-jb-debug/ http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/b2g-inbound-emulator-debug/ http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/b2g-inbound-emulator-kk-debug/

Comment 4

[Gregor Wagner [:gwagner]]

As discussed on IRC we will try to reuse existing emulator gecko builds. We need to package them so they are downloadable and easy to install on a device.

Comment 5

[Aki Sasaki (not active)]

Attachment: emu-nightly-tbpl

I'm not 100% sure about this patch, but it looks like it might work...

Comment 6

[Aki Sasaki (not active)]

Attachment: emulator-gecko-upload

Comment 7

[Aki Sasaki (not active)]

Attachment: emu-nightly

Adds these builders.  This is because depend builds don't do the public upload.

> b2g_mozilla-central_emulator_nightly ScriptFactory
> b2g_mozilla-central_emulator-debug_nightly ScriptFactory
> b2g_mozilla-central_emulator-jb_nightly ScriptFactory
> b2g_mozilla-central_emulator-jb-debug_nightly ScriptFactory
> b2g_mozilla-central_emulator-kk_nightly ScriptFactory
> b2g_mozilla-central_emulator-kk-debug_nightly ScriptFactory
> b2g_mozilla-aurora_emulator_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-debug_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-jb_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-jb-debug_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-kk_nightly ScriptFactory
> b2g_mozilla-aurora_emulator-kk-debug_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator-debug_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator-jb_nightly ScriptFactory
> b2g_mozilla-b2g28_v1_3_emulator-jb-debug_nightly ScriptFactory

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8397493 [details] [diff] [review]
emu-nightly-tbpl

Review of attachment 8397493 [details] [diff] [review]:
-----------------------------------------------------------------

You shouldn't need the debug special-casing (just the plain Nightly lines should suffice). Emulator debug builds/tests are already recognized properly as a different flavor, so nightlies should be no different. Assuming the ASAN ones above it are what's confusing about it, those are a special-case where we want to display the debug build on the same line as the other ASAN builds rather than on their own separate line.

::: js/Data.js
@@ +644,5 @@
>          /b2g.*_tarako_nightly/i.test(name) ? "Tarako Device Image Nightly" :
>          /b2g.*_unagi_nightly/i.test(name) ? "Unagi Device Image Nightly" :
>          /b2g.*_wasabi_nightly/i.test(name) ? "Wasabi Device Image Nightly" :
> +        /b2g.*_emulator.*_debug_nightly/i.test(name) ? "Emulator Device Image Debug Nightly" :
> +        /b2g.*_emulator.*_nightly/i.test(name) ? "Emulator Device Image Nightly" :

Please put this above the Hamachi line to follow the same pattern as the dep builds.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Also, TBPL should work as-is for the device image debug builds without any further changes being necessary.

Comment 10

[Aki Sasaki (not active)]

Attachment: emu-nightly-tbpl

Comment 11

[Aki Sasaki (not active)]

Comment on attachment 8397978 [details] [diff] [review]
emu-nightly-tbpl

https://hg.mozilla.org/webtools/tbpl/rev/a02934b3bf60

Comment 12

[Aki Sasaki (not active)]

Comment on attachment 8397500 [details] [diff] [review]
emu-nightly

https://hg.mozilla.org/build/buildbot-configs/rev/aa84bc5201f8

Comment 13

[Aki Sasaki (not active)]

Comment on attachment 8397499 [details] [diff] [review]
emulator-gecko-upload

https://hg.mozilla.org/integration/b2g-inbound/rev/9a0b874c531b

Comment 14

[Aki Sasaki (not active)]

If we want these emulator debug gecko packages uploaded, I'll need to land https://bugzilla.mozilla.org/attachment.cgi?id=8397499 on all live mozilla-b2g* branches and mozilla-aurora.

Comment 15

[Armen [:armenzg]]

Live in production.

Comment 16

[Jason Smith [:jsmith]]

This is a good idea, but this won't block 1.3.

Comment 17

[Ryan VanderMeulen [:RyanVM]]

(In reply to Aki Sasaki [:aki] from comment #11)
> Comment on attachment 8397978 [details] [diff] [review]
> emu-nightly-tbpl
> 
> https://hg.mozilla.org/webtools/tbpl/rev/a02934b3bf60

Gah, name fixup:
https://hg.mozilla.org/webtools/tbpl/rev/0ff154c63807

Comment 18

[Ryan VanderMeulen [:RyanVM]]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #17)
> (In reply to Aki Sasaki [:aki] from comment #11)
> > https://hg.mozilla.org/webtools/tbpl/rev/a02934b3bf60
> 
> https://hg.mozilla.org/webtools/tbpl/rev/0ff154c63807

In production :)

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/9a0b874c531b

Comment 20

[Aki Sasaki (not active)]

Which branches do we need this on?  i.e. which b2g versions?

Comment 21

[Gregor Wagner [:gwagner]]

(In reply to Aki Sasaki [:aki] from comment #20)
> Which branches do we need this on?  i.e. which b2g versions?

Can we do trunk and 1.4? 1.4 should be aurora.
Thanks for the quick turnaround!

Comment 22

[Aki Sasaki (not active)]

Ok, these are getting uploaded to ftp.

The problem with using http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/latest-mozilla-central/ or http://ftp.mozilla.org/pub/mozilla.org/b2g/nightly/2014-03-28-04-02-02-mozilla-central/ is that the package names are the same for emulator, emulator-jb, and emulator-kk, so we only get one of them in those directories, and it's not clear which one.

There are tinderbox-builds uploads which fix this:
http://ftp.mozilla.org/pub/mozilla.org/b2g/tinderbox-builds/mozilla-central-emulator-jb-debug/1396004522/

If we want to be able to use the nightly upload dirs, we can potentially rename the packages.