98849 - MLK: Memory leak of 1072 bytes from 4 blocks in nsSimpleCharString::ReallocData

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[[e-mail] (gone - use [e-mail] instead)]

[W] MLK: Memory leak of 1072 bytes from 4 blocks allocated in PR_Malloc
        Distribution of leaked blocks
        Allocation location
            malloc+0xc           [dbgheap.c:129 ip=0x002e3c3c]
            PR_Malloc+0x32       [.\../../../../pr/src/malloc/prmem.c:54 
ip=0x30021604]
            nsSimpleCharString::ReallocData(UINT)+0x25c 
[c:\moz_src\mozilla\xpcom\io\nsFileSpec.cpp:267 ip=0x100c994c]
            nsSimpleCharString::CopyFrom(char const*,UINT)+0x56 
[c:\moz_src\mozilla\xpcom\io\nsFileSpec.cpp:184 ip=0x100c9276]
            nsSimpleCharString::nsSimpleCharString(char const*)+0x94 
[c:\moz_src\mozilla\xpcom\io\nsFileSpec.cpp:77 ip=0x100c8994]
            nsFileSpec::nsFileSpec(char const*,int)+0x4a 
[c:\moz_src\mozilla\xpcom\io\nsFileSpec.cpp:997 ip=0x100d071a]
            nsAddrBookSession::GetUserProfileDirectory(nsFileSpec * *)+0x4da 
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAddrBookSession.cpp:141 
ip=0x0fbd40d3]
            nsAbMDBDirFactory::CreateDirectory(UINT,char const* *,WORD const* 
*,nsISimpleEnumerator * *)+0xe26 
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbMDBDirFactory.cpp:145 
ip=0x0fbeb786]
            nsAbBSDirectory::CreateDirectoriesFromFactory(char 
const*,DIR_Server *,UINT,char const* *,WORD const* *,int)+0x441 
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbBSDirectory.cpp:128 ip=0x0fb92c91]
            nsAbBSDirectory::GetChildNodes(nsIEnumerator * *)+0xb7a 
[c:\moz_src\mozilla\mailnews\addrbook\src\nsAbBSDirectory.cpp:241 ip=0x0fb9411a]

Comment 1

[jag (Peter Annema)]

nsFileSpec must die.

Comment 2

[[e-mail] (gone - use [e-mail] instead)]

Bug 98843, bug 98847, bug 98848, bug 98849, bug 98850, bug 98846 and bug 98841 
all were a result of:

Launching mozilla.exe -compose, typing stephe (letting it search from a local 
addressbook for <[e-mail]>, moving the selection down 3 times to 
highlight the above email address, hitting return 3 times, typing nothing in 
the message body, nothing in the subject, and simply hitting OK to send the 
dialog.

Comment 3

[[e-mail] (gone - use [e-mail] instead)]

s/dialog/message

Comment 4

[[e-mail] (gone - use [e-mail] instead)]

changing qa over to myself.

Comment 5

[David :Bienvenu]

taking.

Comment 6

[David :Bienvenu]

Attachment: proposed fix

Comment 7

[(not reading, please use [e-mail] instead)]

Comment on attachment 51331 [details] [diff] [review]
proposed fix

sr=sspitzer

Comment 8

[David :Bienvenu]

fix checked in - unforunately, you'll need purify to verify, unless you want to
look at the code, Stephen.

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Purify, indeeed.  And this is FIXED, using the latest trunk opt build on 
Win32...