Closed Bug 989984 Opened 10 years ago Closed 10 years ago

getShortcutOrURIAndPostData should have a synchronous callback behavior

Categories

(Firefox :: Address Bar, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 31

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

(Keywords: addon-compat)

Attachments

(1 file)

Internal uses of getShortcutOrURIAndPostData should have a synchronous behavior, thus they should not use Promises or Tasks, to allow the conversion in bug 887923 to proceed.
Attached patch The patchSplinter Review
Carrying over r+ from bug 887923.
Attachment #8399393 - Flags: review+
The tryserver build from the original bug is here:

https://tbpl.mozilla.org/?tree=Try&rev=c8d18a501f2a
Keywords: addon-compat
Add-ons that called the Promise variant will need to switch to the callback-based variant, or use the following technique for Promise compatibility:

new Promise(resolve => getShortcutOrURIAndPostData(query, resolve));
https://hg.mozilla.org/mozilla-central/rev/336c25e3063e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Blocks: 996671
QA Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: