Closed
Bug 990872
Opened 10 years ago
Closed 10 years ago
Eliminate Places dependency in Sync utils
Categories
(Firefox :: Sync, defect)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: tatiana, Assigned: rnewman)
Details
Attachments
(2 files)
1.39 KB,
patch
|
rnewman
:
review-
|
Details | Diff | Splinter Review |
8.53 KB,
patch
|
gps
:
review+
|
Details | Diff | Splinter Review |
It would be nice to be able include and use some of services/sync components without dependency on MOZ_PLACES.
Attachment #8400394 -
Flags: review?(mhammond)
Comment 1•10 years ago
|
||
Does this actually allow sync to be used? It seems both services/sync/modules/engines/bookmarks.js and services/sync/modules/engines/history.js need PlacesUtils and would fail without it?
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 8400394 [details] [diff] [review] Allow to use services/sync without MOZ_PLACES defined Review of attachment 8400394 [details] [diff] [review]: ----------------------------------------------------------------- I'll upload a better fix in just a moment.
Attachment #8400394 -
Flags: review?(mhammond) → review-
Assignee | ||
Comment 3•10 years ago
|
||
This simply moves that code closer to the only place it's used, and eliminates the (largely pointless) test. This makes Weave.Utils independent of Places.
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Assignee | ||
Updated•10 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Summary: Allow to use base of Sync services without PLACES dependency → Eliminate Places dependency in Sync utils
Assignee | ||
Comment 4•10 years ago
|
||
Comment on attachment 8400406 [details] [diff] [review] Eliminate Places dependency in Sync utils. r= Services peer for review.
Attachment #8400406 -
Flags: review?(gps)
Comment 5•10 years ago
|
||
Comment on attachment 8400406 [details] [diff] [review] Eliminate Places dependency in Sync utils. r= Review of attachment 8400406 [details] [diff] [review]: ----------------------------------------------------------------- I also would have accepted a patch that moved this method into PlacesUtils.jsm itself :)
Attachment #8400406 -
Flags: review?(gps) → review+
Assignee | ||
Comment 6•10 years ago
|
||
Pushed with tests fixed to match: https://hg.mozilla.org/integration/fx-team/rev/94fa2e17d418 Tatiana, I don't understand what relationship this has with Bug 746800, but given that I just landed the patch for this, I'll assume that it doesn't actually depend on that bug.
No longer depends on: 746800
Comment 7•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/94fa2e17d418
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Reporter | ||
Comment 8•10 years ago
|
||
Thanks a lot!
Updated•6 years ago
|
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in
before you can comment on or make changes to this bug.
Description
•