994562 - Linux: Animated panels (security doorhanger, history panel, bookmarks panel, downloads panel, ...) are invisible/hidden/flash briefly/do not open

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Manos Pitsidianakis]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140409030203

Steps to reproduce:

I click on the download panel button on the UI as usual.


Actual results:

Sometimes it's unresponsive, other times it flashes briefly before closing again.


Expected results:

The download panel should open.

Comment 1

[B.J. Herbison]

Happens for me also on Ubuntu, no problem on Windows 7.

Comment 2

[Alice0775 White]

I can reproduce on ubuntu12.04 GNOME Classic(No effects)

Regression window
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/878193cac6b7
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140408052319
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2c661f15fcd
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140408054720
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=878193cac6b7&tochange=c2c661f15fcd

Regressed by: Bug 610545

Comment 3

[Manos Pitsidianakis]

Bug appears to be on all panels like ssl certificate panel and bookmark panel. Customization panel and menu panel seem fine to me.

Comment 5

[B.J. Herbison]

This also prevents the activation of plugins. On support.addthis.com/customer/portal/articles/381276-flash-examples I can't start flash either by clicking on the plugin or via the spot in the URL bar, the menu doesn't come up.

Comment 6

[Jan Beich]

Bug 980220 fixed similar issue by tuning Linux theme to degrade better without X compositor.

Comment 7

[Alice0775 White]

(In reply to Jan Beich from comment #6)
> Bug 980220 fixed similar issue by tuning Linux theme to degrade better
> without X compositor.

Unfortunately, Bug 980220 did not fix this problem on Ubuntu12.04 GNOME Classic(No effects).
https://hg.mozilla.org/integration/fx-team/rev/6d956b7f8f6e
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140413112937

Comment 8

[B.J. Herbison]

(In reply to Jan Beich from comment #6)
> Bug 980220 fixed similar issue by tuning Linux theme to degrade better without X compositor.

The situation is improved for the bookmarks menu today. It now appears about one in ten clicks. I've never seen the download panel or the panel for approving add-ons since this issue started.

I've also noticed that when the bookmarks menu doesn't appear it is (at least often) still active.

This stealth mode has allowed me to activate my commonly used bookmarks from the keyboard and has kept me from switching browsers so far. (I don't know if this invisible but active state also applies to other panels. I don't have practice using those from the keyboard.)

Comment 9

[Jan Beich]

Attachment: workaround

Comment 10

[Jan Beich]

Attachment: workaround, v0.1

regression fix for either transparent or black-tinted Menu popup in previous patch

Comment 11

[Octoploid]

Also the animation looks cheesy. If I wanted animated menus I would adjust my windowmanager.
Please revert.

Comment 13

[Neil Deakin]

I'm assuming that this is a issue on Linux only with/without a compositor or something like that. So we can likely either something like the patch above, (although I haven't tested it myself), or just disable the animation on Linux for now.

For the patch in comment 10, the changes need to be made in xul.css instead of the Linux-specific popup.css so that it works on other themes. Conditionals can be used here to make it Linux specific.

For disabling the transition, this would involve putting the arrow panel related styles in xul.css inside a not Linux conditional block. You could also or instead add a default animate="false" on Linux to the arrow panel's binding.

For all of the above, the same applies to the bookmarks menu which uses different styles related to #BMB_bookmarksPopup.

Comment 15

[Nix\]

(In reply to Neil Deakin from comment #13)
> I'm assuming that this is a issue on Linux only with/without a compositor or
> something like that. So we can likely either something like the patch above,
> (although I haven't tested it myself), or just disable the animation on
> Linux for now.
> 
> For the patch in comment 10, the changes need to be made in xul.css instead
> of the Linux-specific popup.css so that it works on other themes.
> Conditionals can be used here to make it Linux specific.
> 
> For disabling the transition, this would involve putting the arrow panel
> related styles in xul.css inside a not Linux conditional block. You could
> also or instead add a default animate="false" on Linux to the arrow panel's
> binding.
> 
> For all of the above, the same applies to the bookmarks menu which uses
> different styles related to #BMB_bookmarksPopup.

My bug was marked as duplicated of this bug, see the screencast that I recorded about this please.
I use CentOS 6.5 with NO composition or similar, and the bug appear un 2014-04-08 31, is present too in bookmarks mini-window after add a new site.

Comment 16

[Nix\]

screencast of the bug, CentOS 6.5 i686 gnome 2.28 no composition enabled:

https://bugzilla.mozilla.org/show_bug.cgi?id=996567

Comment 17

[Nix\]

(In reply to Neil Deakin from comment #13)
> I'm assuming that this is a issue on Linux only with/without a compositor or
> something like that. So we can likely either something like the patch above,
> (although I haven't tested it myself), or just disable the animation on
> Linux for now.
> 
> For the patch in comment 10, the changes need to be made in xul.css instead
> of the Linux-specific popup.css so that it works on other themes.
> Conditionals can be used here to make it Linux specific.
> 
> For disabling the transition, this would involve putting the arrow panel
> related styles in xul.css inside a not Linux conditional block. You could
> also or instead add a default animate="false" on Linux to the arrow panel's
> binding.
> 
> For all of the above, the same applies to the bookmarks menu which uses
> different styles related to #BMB_bookmarksPopup.

I Agree.

Comment 18

[Jan Beich]

Attachment: workaround, limited opacity transition

Only |opacity| transition becomes broken without X compositor, |transform| still looks fine. No need for |animate="false"| unless it looks better than without.

ifdefs used aren't limited to Linux per bug 948946

Comment 19

[Jan Beich]

Attachment: workaround, no opacity transition

May or may not look better without X compositor than if transition uses black color in place of translucency.

Comment 20

[Jan Beich]

Attachment: workaround, limited opacity transition

Oops, limit to X11 as compositing on non-X11 (e.g. Wayland) may behave differently.

Comment 21

[Jan Beich]

Attachment: screencast (120fps), limited opacity transition patch, no X compositor

Black tint, visible black background and choppy animation are transition artifacts without X compositor.

Comment 22

[Jan Beich]

Attachment: screencast (120fps), limited opacity transition patch, with X compositor

Comment 23

[Benjamin Kerensa [:bkerensa]]

Tracking this due to user impact and regression.

Comment 24

[Alice0775 White]

It is time to backed out Bug 610545 for next ESR31.

Comment 26

[B.J. Herbison]

The situation is much worse with today's build. I've been getting by with typing characters to an invisible bookmarks menu, but that has stopped working. (An I still can't enable plugins.)

As Alice said: It is time to back out Bug 610545 for next ESR31.

Comment 28

[Francesca Ciceri [:madamezou]]

Hi,

experimented this one first time today with Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140429030201 CSet: d7c07694f339 (Debian Sid). Happens in Safe Mode and with a clean profile also, with the default theme.
The Download menu is affected as well.

Let me know if you need more info.

Cheers,
Francesca

Comment 29

[Jan Beich]

Comment on attachment 8408949 [details] [diff] [review]
workaround, limited opacity transition

This patch tries to follow bug 980220 example where X compositor look doesn't degrade much. If you do not agree, attachment 8408944 [details] [diff] [review] has less animation, still with artifacts, but provides more consistent look between with/without X compositor (no screencast yet).

Comment 31

[Chris Siebenmann]

I'm another Linux user affected by this issue. If it helps, I'm using
FVWM with an ATI card and the open-source drivers on Fedora 20 (exact
details available if they're helpful). For me, the problem is that
various panels are invisible or do not open.

I used Mercurial bisection to identify the exact changeset that introduces
the problem for me and it is e4f3408af361, 'Bug 610545, arrow panels
should animate when opening and when cancelling, r=neil,dao'.

The patch from comment 29 works but the result doesn't look particularly
good on my system; the animation feels slow and obtrusive. I personally
would prefer no animation and the panels to just appear and disappear
promptly (as they did before this issue showed up, which I believe means
before bug 610545 landed).

Comment 32

[Neil Deakin]

Chris, or others, does this patch in this bug fix the problem for you?

Comment 33

[Chris Siebenmann]

The patch attachment from comment 29 'works' in that panels appear.
The appearance and disappearance animation looks ugly and jerky,
especially the disappearance animation (where large black sections
visibly blink into existence for large panels). The screencast from
comment 22 is a mild but representative example; watch the sections
of black tear into and out of existence.

(It's mild because the panels are small.)

If there is another patch that I should try, let me know which one
it is. I'm a bit lost in all of the versions of things in this bug
(many of them marked as superseded).

Based on the patch attachment from comment 29, I believe that the entire
transition animations should be backed out on Linux and things reverted
to the pre Bug 610545 state. There are clearly a noticeable number of
Linux users affected by this and the 'fixed' version here is slow and
brutally ugly.

(As one anecdotal data point, I've stopped updating my 'tip of tree'
build version because I can't stand the new animation.)

Comment 38

[Chris Siebenmann]

For the record: I like the patch in bug 1001234 significantly more than
the patch in comment 29. The former patch avoids the visible 'tearing'
and black chunks that appear with the comment 29 patch. (This may be
unnecessary to mention, since it looks like the patch from bug 1001234
is being integrated, but I'm throwing it in for the record.)

Comment 40

[Nix\]

This bug of nighttly was landed in Aurora 31a02. What version was patched actually?.
Actually Firefox Aurora Latest i686 have the bug working on CentOS 6.5 i686.

Comment 41

[Nix\]

The bug is fixed in firefox-32.0a1.es-AR.linux-i686.tar.bz2.
Landed the same bug in Aurora 310a2 too, is a good idea a new tarball with the patch in Aurora branch.

Comment 43

[Frederik Braun [:freddy]]

Despite being resolved it still affects users of aurora on linux. A lot of features are close to be unusable for a lot of people. Would it make sense to request an uplift?

Comment 45

[nemo]

FWIW, bug #1015398 is in that alpha branch that comment #43 points out is lacking the backport.  So, I guess properly duped, but unfixed for people on the alpha.  Does that mean it'll eventually hit beta and stable too?

Comment 46

[nemo]

Eh. n/m. I fail at reading comments. Sorry.  It *was* backported.
"Version 31.0a2: Bug 1015398 and bug 994562 not reproducible (presumably fixed)."

Sorry, was just a tad worried since allll my machines over here are linux and didn't want to have to support a bunch of confused relatives.

Comment 47

[(Currently slow to respond) Philipp Sackl [:phlsa] (Firefox UX) please use needinfo]

Comment on attachment 8408949 [details] [diff] [review]
workaround, limited opacity transition

This seems to be fixed, so I'm cancelling ui-review.
Sorry for not acting on it, somehow this flew by me without myself noticing.

Comment 48

[Sylvestre Ledru [:Sylvestre]]

Neil, can we have an uplift request for beta? Thanks

Comment 49

[Francesca Ciceri [:madamezou]]

Hi,

reproduced on Firefox/31.0 ID:20140414030203 and verified the fix on latest Aurora (32.0a2 2014-06-23) on Debian (Linux) x86_64.

Thanks for fixing it: it was really irritating :)

Cheers,
Francesca

Comment 50

[Marco Mucci [:MarcoM]]

Hi Neil, can you provide a point value and if the bug should be marked as [qa+] or [qa-].

Comment 51

[Neil Deakin]

The animation is disabled on Linux, so this patch doesn't do anything currently and hasn't been checked in anywhere.

Comment 52

[Francesca Ciceri [:madamezou]]

(In reply to Neil Deakin from comment #51)
> The animation is disabled on Linux, so this patch doesn't do anything
> currently and hasn't been checked in anywhere.

Ops, so that's why it seemed fixed during verification. :)
Should I change it back from Verified to Resolved?

Cheers,
Francesca

Comment 53

[Sylvestre Ledru [:Sylvestre]]

I would say Unaffected

Comment 54

[Marco Mucci [:MarcoM]]

Removing from Backlog - Neil stated that Bug 994562 was fixed by Bug 1001234 which was in iteration 32.1