99698 - xpcom needs glue static lib

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Doug Turner (:dougt)]

Per meeting, xpcom needs a glue directory which builds a static library.  The
first addition to this library would be nsCOMPtr.

This library should be linked into xpcom.

Comment 1

[cls]

Ok, the directory is created and dawn copied xpcom/base/nsCOMPtr.* to xpcom/glue/. 

Comment 2

[cls]

Attachment: add xpcomglue to unix build

Comment 3

[Alec Flett]

Comment on attachment 49415 [details] [diff] [review]
add xpcomglue to unix build

sr=alecf

Comment 4

[cls]

Attachment: add xpcom\glue to win32 build

Comment 5

[Alec Flett]

Comment on attachment 49880 [details] [diff] [review]
add xpcom\glue to win32 build

sr=alecf

Comment 6

[rpotts (gone)]

Comment on attachment 49880 [details] [diff] [review]
add xpcom\glue to win32 build

r=[e-mail]

Comment 7

[cls]

I need some mac assistance here (and/or someone to ship me a dual g4 ;)).  We 
need a new project file for xpcom:glue which will build the xpcomglue.lib from 
nsCOMPtr.cpp & export nsCOMPtr.h. We also need to modify xpcom:build & xpcom's 
project files to build the glue project and to link xpcomglue.lib into 
xpcom.shlib .

Comment 8

[hacker formerly known as [e-mail]]

Attachment: xpcomPPC.mcp updated to build nsCOMPtr.cpp from {Project}::glue

Comment 9

[hacker formerly known as [e-mail]]

Comment on attachment 51041 [details]
xpcomPPC.mcp updated to build nsCOMPtr.cpp from {Project}::glue

botched it. new project coming up

Comment 10

[hacker formerly known as [e-mail]]

Attachment: let's try that again

Comment 11

[hacker formerly known as [e-mail]]

Attachment: Process xpcom:glue:MANIFEST

Comment 12

[hacker formerly known as [e-mail]]

Attachment: remove nsCOMPtr.h from xpcom:base:MANIFEST

Comment 13

[Alec Flett]

Comment on attachment 51079 [details] [diff] [review]
Process xpcom:glue:MANIFEST

sr=alecf

Comment 14

[Alec Flett]

Comment on attachment 51080 [details] [diff] [review]
remove nsCOMPtr.h from xpcom:base:MANIFEST

sr=alecf

Comment 15

[Axel Hecht]

Could we get a rationale, or summary of that meeting?

Thanx

Axel

Comment 16

[hacker formerly known as [e-mail]]

30s-I-just-woke-up-summary:

We need to freeze a subset of xpcom (called glue) that all applications that use
xpcom can link against and still have their components work with future revs of
an xpcom app.  Since most of the code in question are inline macros, the plan is
to make this glue library static initially.

All the patches & project files are in.  Marking fixed.  Open a new patch for
the next set of files to be moved over.