1118126 - MSE: Changing MediaSource::duration attribute, do not evict data

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

When modifying MediaSource::duration attribute, if new duration is lesser than the existing one, we should be removing data from the attached source buffers.

Per spec:
duration change:
http://w3c.github.io/media-source/#duration-change-algorithm
"If the new duration is less than old duration, then run the range removal algorithm with new duration and old duration as the start and end of the removal range."

http://w3c.github.io/media-source/#sourcebuffer-coded-frame-removal

This is causing Youtube reference test #23 and #24 to fail

Comment 1

[Jean-Yves Avenard [:jya]]

in the attached test:
we can see:
4409: video.duration=4.986366
4410: sourceBuffer.buffered.length = 1
4411: sourceBuffer.buffered.start(0) = 0.0326
4412: sourceBuffer.buffered.end(0) = 10.005333
4412: mediaSource.duration = 4.9863665

Should be:
4409: video.duration=4.986366
4410: sourceBuffer.buffered.length = 1
4411: sourceBuffer.buffered.start(0) = 0.0326
4412: sourceBuffer.buffered.end(0) = 5.0189665
4412: mediaSource.duration = 4.9863665

Comment 2

[cajbir (:cajbir)]

Where are these attached tests?

Comment 3

[Jean-Yves Avenard [:jya]]

see the URL field.

Going to make them into mochitest

Comment 4

[Jean-Yves Avenard [:jya]]

Addendum:
4409: video.duration=4.986366
4410: sourceBuffer.buffered.length = 1
4411: sourceBuffer.buffered.start(0) = 0.0326
4412: sourceBuffer.buffered.end(0) = 10.005333
4412: mediaSource.duration = 4.9863665

should be:
4305: * sourceBuffer.updatestart
4305: * sourceBuffer.update
4305: * sourceBuffer.updateend
4409: video.duration=4.986366
4410: sourceBuffer.buffered.length = 1
4411: sourceBuffer.buffered.start(0) = 0.0326
4412: sourceBuffer.buffered.end(0) = 5.0189665
4412: mediaSource.duration = 4.9863665

event updatestart/update/updateend must be fired

Comment 5

[Jean-Yves Avenard [:jya]]

Attachment: MSE: Partially implement Range Removal algorithm

Initial incomplete implementation. Works with youtube, resolution change are now instantaneous

Comment 6

[Jean-Yves Avenard [:jya]]

Attachment: MSE: Partially implement Range Removal algorithm

Initial incomplete implementation. Works with youtube, resolution change are now instantaneous

Comment 7

[Jean-Yves Avenard [:jya]]

Fixed by bug 1130826