Eyedropper and Style Editor use/share same commandkey: 'y', but should be different

RESOLVED FIXED in Firefox 31

Status

()

defect
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

Trunk
Firefox 31
x86_64
Windows 8.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lang=text][mentor=aryx])

Attachments

(1 attachment, 1 obsolete attachment)

Firefox Nightly 20140422030204 on Windows 8.1

In Tools > Web Developer, 'Eyedropper' and 'Style Editor' use the same accesskey 'y' for accessing the menu items with the keyboard. They should be different.
Posted patch patch, v1 (obsolete) — Splinter Review
This patch changes the one of 'Style Editor' to 'l' because all the letters in 'Eyedropper' are already used elsewhere and 'l' is the only available letter which doesn't duplicate an access key. Unfortunately, that letter isn't wide.

With devtools.chrome.enabled and remote debugger enabled, there are 17 menu items with 16 accesskeys. Two available letters in other labels are 'g' (several occurences) and 'k' (Network) - we could also change the access key for Page Source from 'o' to 'g' and use the 'o' e.g. for Eyedropper.

Furthermore, I changed the accesskey for App Manager from lowercase 'a' to uppercase 'A' so the first letter of the label gets underlined.
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #8412620 - Flags: review?(jaws)
Comment on attachment 8412620 [details] [diff] [review]
patch, v1

Review of attachment 8412620 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/browser/browser.dtd
@@ +258,5 @@
>  <!ENTITY devToolbarCloseButton.tooltiptext "Close Developer Toolbar">
>  <!ENTITY devToolbarMenu.label              "Developer Toolbar">
>  <!ENTITY devToolbarMenu.accesskey          "v">
>  <!ENTITY devAppMgrMenu.label               "App Manager">
> +<!ENTITY devAppMgrMenu.accesskey           "A">

Please update the entity name here since other locales that continue to use "App Manager" as the label may want to update their accesskey to match.

::: browser/locales/en-US/chrome/browser/devtools/styleeditor.properties
@@ +57,5 @@
>  open.commandkey=VK_F7
>  
>  # LOCALIZATION NOTE (open.accesskey): The access key used to open the style
>  # editor.
> +open.accesskey=l

Ditto.
Attachment #8412620 - Flags: review?(jaws) → review-
From IRC:
<I> 23.04.2014 10:17:02 hi, can you please take a look at https://bugzilla.mozilla.org/show_bug.cgi?id=1000002 and tell me if it requires a string change?
<flod> 23.04.2014 10:41:13 no, accesskeys don't require new ID, since each locale has its own

But I can see where you are coming from. ni Pike
Flags: needinfo?(l10n)
Yeah, no ID change. Might be good to post to .l10n to get folks' attention, though.
Flags: needinfo?(l10n)
Comment on attachment 8412620 [details] [diff] [review]
patch, v1

Review of attachment 8412620 [details] [diff] [review]:
-----------------------------------------------------------------

Ok, sounds good. Thanks for double-checking. Can you send the post to the l10n mailing list?
Attachment #8412620 - Flags: review- → review+
Thanks, I will post to mozilla.dev.l10n after the patch has landed.
Attachment #8412620 - Attachment is obsolete: true
https://hg.mozilla.org/integration/fx-team/rev/4af2b4c97db5
Keywords: checkin-needed
Whiteboard: [lang=text][mentor=aryx] → [lang=text][mentor=aryx][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/4af2b4c97db5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [lang=text][mentor=aryx][fixed-in-fx-team] → [lang=text][mentor=aryx]
Target Milestone: --- → Firefox 31
QA Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.