Closed Bug 1000050 Opened 6 years ago Closed 6 years ago

[Gallery][UX] Thumbnail selection header UX is not consistent

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: ranjith253, Assigned: ranjith253)

Details

(Whiteboard: [g+])

Attachments

(2 files, 1 obsolete file)

Attached image select.png
User Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140410030200

Steps to reproduce:

Select header background color is not consistent in pick mode 
& normal mode.
Flags: needinfo?(jsavory)
Hi,

Any UI spec document related to this?
Forwarding this one to Amy who is currently the visual designer for Gallery.
Flags: needinfo?(jsavory) → needinfo?(amlee)
(In reply to jsavory from comment #2)
> Forwarding this one to Amy who is currently the visual designer for Gallery.

Hi, 

The gallery header should be consistent across the OS (i.e dark). Can you please change the white header to match the dark one? Thanks!
Flags: needinfo?(amlee)
(In reply to Amy Lee [:amylee] from comment #3)
> (In reply to jsavory from comment #2)
> > Forwarding this one to Amy who is currently the visual designer for Gallery.
> 
> Hi, 
> 
> The gallery header should be consistent across the OS (i.e dark). Can you
> please change the white header to match the dark one? Thanks!
Thanks amy , I will make the required changes.
Attached file Pointer to Pull Request (obsolete) —
Hi,

I have made changes according to Amy's decision, can you review the code?
Attachment #8412487 - Flags: review?(johu)
Comment on attachment 8412487 [details]
Pointer to Pull Request

Thanks for this patch. It's cool. But I feel we may need to change all skin-organic to skin-dark.

I don't know why you don't change all of them. If you had found anything preventing you to change all of them, please be kind to tell me. Thanks.
Attachment #8412487 - Flags: review?(johu)
Whiteboard: [g+]
Hi,

I have made the changes as suggested by you & i have no issue's in changing organic to dark in other places.
Attachment #8412487 - Attachment is obsolete: true
Attachment #8414316 - Flags: review?(johu)
Assignee: nobody → ranjith253
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Comment on attachment 8414316 [details]
Pointer to Pull Request

Cool. Thanks for this patch.
Attachment #8414316 - Flags: review?(johu) → review+
merged to master:
https://github.com/mozilla-b2g/gaia/commit/963f4a520aa0edfce62ed4a125bdeb6f6d51b71e
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.