1000050 - [Gallery][UX] Thumbnail selection header UX is not consistent

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[ranjith253]

Attachment: select.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140410030200

Steps to reproduce:

Select header background color is not consistent in pick mode 
& normal mode.

Comment 1

[ranjith253]

Hi,

Any UI spec document related to this?

Comment 2

[Jacqueline Savory [:jsavory] UX]

Forwarding this one to Amy who is currently the visual designer for Gallery.

Comment 3

[Amy Lee [:amylee] UX]

(In reply to jsavory from comment #2)
> Forwarding this one to Amy who is currently the visual designer for Gallery.

Hi, 

The gallery header should be consistent across the OS (i.e dark). Can you please change the white header to match the dark one? Thanks!

Comment 4

[ranjith253]

(In reply to Amy Lee [:amylee] from comment #3)
> (In reply to jsavory from comment #2)
> > Forwarding this one to Amy who is currently the visual designer for Gallery.
> 
> Hi, 
> 
> The gallery header should be consistent across the OS (i.e dark). Can you
> please change the white header to match the dark one? Thanks!
Thanks amy , I will make the required changes.

Comment 5

[ranjith253]

Attachment: Pointer to Pull Request

Hi,

I have made changes according to Amy's decision, can you review the code?

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8412487 [details]
Pointer to Pull Request

Thanks for this patch. It's cool. But I feel we may need to change all skin-organic to skin-dark.

I don't know why you don't change all of them. If you had found anything preventing you to change all of them, please be kind to tell me. Thanks.

Comment 7

[ranjith253]

Attachment: Pointer to Pull Request

Hi,

I have made the changes as suggested by you & i have no issue's in changing organic to dark in other places.

Comment 8

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8414316 [details]
Pointer to Pull Request

Cool. Thanks for this patch.

Comment 9

[John Hu [:johnhu][:johu][:醬糊小弟]]

merged to master:
https://github.com/mozilla-b2g/gaia/commit/963f4a520aa0edfce62ed4a125bdeb6f6d51b71e