Closed Bug 1000085 Opened 6 years ago Closed 5 years ago

panel.css should be in non-shared code

Categories

(Hello (Loop) :: Client, defect, P4, trivial)

defect
Points:
1

Tracking

(Not tracked)

RESOLVED FIXED
mozilla37
Iteration:
37.3 - 12 Jan
Blocking Flags:
backlog Fx37+

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [tech-debt])

Attachments

(1 file)

Panel.css should be in non-shared code, i.e. just for the desktop.

It doesn't make sense to move it at the moment, we should do this when we adjust the repositories at the time (or just after) we do bug 994485.
Panel.css is currently shared because it's used by the readme.html file. I agree it doesn't make sense to share it for that sole purpose though. 

We should probably wait for desktop loop to become authoritative to reconsider our asset sharing strategy.
Whiteboard: [tech-debt]
backlog: --- → Fx36+
backlog: Fx36+ → Fx37+
I moved both the contact.css and the panel.css file as these are fine.

The relative directories are necessary to support the showcase, so I updated those.

I didn't publish this in reviewboard due to bug 1117086.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Attachment #8543261 - Flags: review?(mdeboer)
Comment on attachment 8543261 [details] [diff] [review]
Moves panel.css and contact.css

Review of attachment 8543261 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8543261 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/60901e935dd6
Iteration: --- → 37.3
Points: --- → 1
Target Milestone: --- → mozilla37
https://hg.mozilla.org/mozilla-central/rev/60901e935dd6
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.