1000107 - Client re-sync contact information from Google

Status: RESOLVED DUPLICATE of bug 972079

(Hello (Loop) :: Client, defect, P3)

Comment 1

[Romain Testard [:RT]]

This only updates the locally stored Google contacts.

Comment 2

[Romain Testard [:RT]]

Darrin, I assume the UX will be as follows but can you please confirm and amend the UX doc accordingly:
* If Google contacts have already been imported, the "Import contacts" button becomes a "Re-Sync contacts" button.
* The "Re-sync" contacts button opens the Google contacts permission flow in a new tab

Comment 3

[Romain Testard [:RT]]

The user should not have to authenticate through OAUTH given that he should have already authenticated when he first imported his contacts.
If the stored credentials are still valid don't prompt the user to OAUTH.

Comment 4

[Darrin Henein [:darrin]]

(In reply to Romain Testard [:RT] from comment #2)
> Darrin, I assume the UX will be as follows but can you please confirm and
> amend the UX doc accordingly:
> * If Google contacts have already been imported, the "Import contacts"
> button becomes a "Re-Sync contacts" button.
> * The "Re-sync" contacts button opens the Google contacts permission flow in
> a new tab

Exactly.

Comment 5

[Dão Gottwald [:dao]]

Can somebody please point me to where this code lives?

Comment 6

[Mark Banner (:standard8)]

We have no contact code currently. The general loop code is under browser/components/loop.

There's some more information and at least one related PoC patch on bug 972000.

You can also find us in #media if you have questions.

Comment 7

[Dão Gottwald [:dao]]

I'm confused. How can there be "locally stored Google contacts", which this bug is supposed to update (comment 1), if there's no contact code? Is this bug not yet ready to be worked on?

Comment 8

[Mark Banner (:standard8)]

I think it isn't ready. This should, at a minimum, depend on bug 972079, if not others as well.

Not quite sure why it was allocated => needinfo Shell/Marco.

Comment 9

[Maire Reavy [:mreavy]]

Adam just put up a write up for Contacts: https://wiki.mozilla.org/Loop/Architecture/Address_Book

We haven't done the sync work yet. tOkeshu wrote code for local contacts (not Google).  Google contacts won't be editable locally in the first release of Loop;  the user can sync and update but not edit Google contacts.  Only local-created contacts are editable in Loop for Fx 34.

tOkeshu was working on Bug 1000112 until last week.  He has his code in github (a link is in that bug), and he is working now on posting his code as a patch against trunk in that bug (Bug 1000112).

We definitely need to get sync working (bug 972079) before we implement re-sync.   I believe we want to work on the initial Google sync work (bug 972079) and/or we want to pick up bug 1000112 from tOkeshu for this print. The Google sync work is what our partners are looking for in Fx 34 (so that is a higher priority).

Comment 10

[Dão Gottwald [:dao]]

Marco, please remove this from the current iteration.

Comment 11

[Marco Mucci [:MarcoM]]

Removed from Iteration 33.3

Comment 12

[Maire Reavy [:mreavy]]

The backend for the resync was handled in Bug 972079

The front end for viewing the imported contact will be handled bug 1000766