100015 - Editor content context menu shouldn't collapse its menuitems

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[[e-mail]]

Using Build ID: 2001091403
Steps to reproduce problem:
1. Open a new composer window
2. Open the content context menu

Actual results: Context menu has blank gap at the bottom.

Expected results: Unwanted menuitems should be completely undetectable.

Additional information: Try repeatedly pressing down arrow.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Kathleen :Brade]

-->cmanske
r=brade

Comment 3

[[e-mail]]

CCing [e-mail] for sr

Comment 4

[Charles Manske]

Wait! I already have these changes plus other tweaks to the context menu in my
tree. This is actually a dup of another bug.

Comment 5

[Charles Manske]

Attachment: My version of the fix, with minor differences to cleanup context menu code

Comment 6

[Charles Manske]

I can't find the original bug on this issue -- it was sent to XPFE group.
The menu widget arrow navigation should skip over both "collapsed" and 
"hidden" items; the issue was seen only in Composer 'cause we used 'collapsed'
while other modules used 'hidden'. So I didn't check in my fix so they would have
a test case. But at this point, I agree we should probably just checkin a fix
for Composer so the menu works right even if other bug isn't fixed.
As you can see, my patch does everything Neil's does, plus some other cleanup,
such as consistent use of " instead of '.
Neil or Kathy: Could you please r= my fix?

Comment 7

[Joe Hewitt (gone)]

sr=hewitt

Comment 8

[Charles Manske]

checked in

Comment 9

[sujay]

Neil, can you verofy this on the latest build and mark
VERIFIED? thanks.

Comment 10

[Charles Manske]

Sujay: You can verify: Open a popup menu and use down arrow key -- each keypress
should go to the next item. That was the original issue that caused these changes.
But since I just did that, I guess I can mark it verified.