1000160 - Super search gives no results for release-as-beta (b99)

Status: RESOLVED FIXED

(Socorro :: Backend, task, P1)

Description

[Robert Kaiser]

When we ship the release (candidate) build on the beta channel, it shows up in Socorro as "b99", for example 29.0b99 right now.

Advanced search returns results for that:
https://crash-stats.mozilla.com/query/?product=Firefox&version=Firefox%3A29.0b99&range_value=1&range_unit=weeks&date=04%2F23%2F2014+13%3A00%3A00&query_search=signature&query_type=contains&query=&reason=&release_channels=&build_id=&process_type=any&hang_type=any

Super search doesn't:
https://crash-stats.mozilla.com/search/?version=29.0b99&_facets=signature&_columns=date&_columns=signature&_columns=product&_columns=version&_columns=build_id&_columns=platform

Comment 1

[[DEACTIVATED] Adrian Gaudebert]

All the logic around our beta versions happens in a PostgreSQL stored procedure. Those changes never make it to the processed crashes, and thus are not available in Super Search. I believe we should move that logic from the stored procedure to the processors, so those improved version numbers can be seen in all our databases instead of just postgres. 

:lars, :selenamarie, do you think that is doable?

Comment 2

[Selena Deckelmann :selenamarie :selena]

Discussed this on IRC. The logic is primarily in the ftpscraper. I'm looking now at factoring it out, so that it could be used by multiple modules.

Comment 3

[[DEACTIVATED] Adrian Gaudebert]

I'll be working on this at the beginning of next quarter, with the intention of fixing this problem for all databases at once, by moving the rules into our processors. It should allow us to remove a bunch of logic from some SQL queries and auto-magically fix Super Search.

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/7335b93d1fa6c52e89ed7ebffe97042b462cf806
Fixes bug 1000160 - Set the correct version number in processed crashes. r=rhelmer,twobraids

https://github.com/mozilla/socorro/commit/7ec9d4068116ad5ad5fa911940322eee6e144f7c
Bug 1000160 - Added migration for update_reports_clean.

https://github.com/mozilla/socorro/commit/4169074a7ae603be8b1c7245c9a165f64ed7e2d1
Merge pull request #2725 from AdrianGaudebert/1000160-correct-version-in-processed-crash

Fixes bug 1000160 - Set the correct version number in processed crashes.

Comment 6

[[DEACTIVATED] Adrian Gaudebert]

Migration was successfully ran on stage.

Comment 7

[[DEACTIVATED] Adrian Gaudebert]

https://crash-stats.allizom.org/search/?product=Firefox&version=38.0b8 !!!!!11!1!!!

Comment 8

[Robert Kaiser]

That looks good, but there is no way any more to search for everything that originally has "38.0" in their version, is there?

Comment 9

[Robert Kaiser]

Also, it looks like all crashes before this landed are only searchable the old way, and all those recorded after are only searchable the new way. That complicates things somewhat for the moment...

Comment 10

[Robert Helmer [:rhelmer]]

Migration was successfully run for this on production this morning (~7 Pacific)

Comment 11

[Robert Helmer [:rhelmer]]

(In reply to Robert Kaiser (:[e-mail]) from comment #8)
> That looks good, but there is no way any more to search for everything that
> originally has "38.0" in their version, is there?

No, these will be recorded everywhere with the new version string, except for the original raw crash in S3.

(In reply to Robert Kaiser (:[e-mail]) from comment #9)
> Also, it looks like all crashes before this landed are only searchable the
> old way, and all those recorded after are only searchable the new way. That
> complicates things somewhat for the moment...

We could reprocess further back in time if that is helpful.

Comment 12

[Robert Kaiser]

(In reply to Robert Helmer [:rhelmer] from comment #11)
> (In reply to Robert Kaiser (:[e-mail]) from comment #8)
> > That looks good, but there is no way any more to search for everything that
> > originally has "38.0" in their version, is there?
> 
> No, these will be recorded everywhere with the new version string, except
> for the original raw crash in S3.

Hrm, that probably means we will need to have some kind of functionality that makes sure that we can still search for "everything on 38.*" and of course it's vital that we can search for the magic "38.0b" as well.

Comment 13

[[DEACTIVATED] Adrian Gaudebert]

Bug 1155416 for being able to search for more version patterns. 
Bug 1161030 for the magic "38.0b" thing.