1000173 - Display a user visible icon when remotely enabling Where's My Fox / Find My Device

Status: RESOLVED FIXED

(Firefox OS Graveyard :: FindMyDevice, defect)

Description

[Curtis Koenig [:curtisk-use curtis.koenig+bzATgmail.com]]]

When a user enables this feature we may want to display a user visible icon in the notification area that the feature is enabled. This would alter users if someone has enabled the feature for them without their knowledge. However this may also alter attackers the feature is enabled and prompt them to power off the phone. 
Discussion of this was in the public comment thread (https://groups.google.com/forum/#!topic/mozilla.dev.planning/sDCuDrLyTcs) for the privacy review and the thinking is we should make a definitive decision on the feature as this has implications for domestic violence situations.

Comment 1

[Erin Lancaster [:elan]]

Assigning to Bryan Bell who is leading the charge on vis design of the website.

Comment 2

[Erin Lancaster [:elan]]

Apologies, I reversed this. Not for web; for device UX. She'll check on notifications vs status bar.

Comment 3

[Kate Glazko]

Is this landing tomorrow?

Comment 4

[Erin Lancaster [:elan]]

It doesn't look like it...

Comment 5

[Jacqueline Savory [:jsavory] UX]

Looking at our options, I don't think that either the notifications or status bar will work for this problem. 

Erin has suggested we look into including this in settings and I will work on a proposal for an active state in the Find my Device settings.

Comment 6

[bhavana bajaj [:bajaj]]

This looks like missed feature work, so tagging it accordingly

Comment 7

[Jacqueline Savory [:jsavory] UX]

Attachment: FMD-RemoteEnable-June10.pdf

I've attached the spec for the notification within settings to show the user if they are actively being tracked by the website. Let me know if there are any questions.

Comment 8

[Kate Glazko]

Attachment: Pull Request

Comment 9

[Théo Chevalier]

Hey guys, the string freeze for 2.0 was today, if it's ready please land it ASAP (likely this weekend) if you want it to make it for 2.0, otherwise contact the l10n team. Thanks

Comment 10

[Guilherme Gonçalves [:ggp]]

Attachment: gaia pull request

Kate, thank you so much for working on this. Great job!

I took another look at the patch today, because we're trying to get it landed ASAP, and there were still some final details to be fixed, so I addressed them. I'm attaching a new pull request; it's green on my private Travis instance: https://travis-ci.org/guilherme-pg/gaia/builds/28110233

Arthur, the priority here is to get the strings landed, so I'll be happy to postpone the code changes and provide a patch containing only the strings if you think that's better. Thank you!

Comment 11

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8443938 [details] [review]
gaia pull request

r=me with the comment addressed, thanks!

Comment 12

[Guilherme Gonçalves [:ggp]]

Done, thank you!

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

Hi Guilherme,

We should also update the unit tests. Please check my comments in github.

Comment 14

[Guilherme Gonçalves [:ggp]]

Actually, let's hold this back for a moment. I'm having issues with FxA that are preventing me from testing this, and Arthur just pointed out I broke the unit tests :/

Comment 15

[Guilherme Gonçalves [:ggp]]

Looking better now I think. The unit tests pass locally, and I was able to hack FxA enough to do some manual testing too. Apologies for messing up on the first time, I'll set checkin-needed once I get an actual green Travis.

Comment 16

[Guilherme Gonçalves [:ggp]]

PR updated to reflect Arthur's comments about mocking navigator.mozL10n.localize. Thanks for that! :)

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/8e6f9edf6c0b7ec484c3f120c588d3d33e3e21b8

Comment 18

[Guilherme Gonçalves [:ggp]]

Comment on attachment 8443938 [details] [review]
gaia pull request

NOTE: Please see https://wiki.mozilla.org/Release_Management/B2G_Landing to better understand the B2G approval process and landings.

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: This poses a privacy concern as the user won't be able to know if he's being tracked without consent
[Testing completed]: Travis and manual.
[Risk to taking this patch] (and alternatives if risky): No risk.
[String changes made]: Two strings were added to the Settings app.

Comment 19

[bhavana bajaj [:bajaj]]

a=bajaj for the patch. We have an ongoing discussion with the l10n team to get this landed by monday morning am, I am flagging :pike/:flod to give a formal l10n approval before I go ahead and approve this patch.

Comment 20

[Axel Hecht [:Pike]]

Neither flod nor I are the people to talk here.

If you wanted feedback, it'd probably be by chofmann. Not to take too many of his words out of his mouth, but the plan was to be done on Friday. That plan didn't work out. You need a new plan, and create a schedule out of it.

Individual bugs don't matter beyond technical regressions introduced by them.

Comment 21

[Axel Hecht [:Pike]]

Erin, I don't understand why folks insist on asking for feedback on this bug.

We need a plan now that we busted string freeze, and this bug is only one of a few.

Also redirecting the feedback request to the right chofmann.

Comment 22

[Théo Chevalier]

We just had a talk with Erin and Chris, I think we now are on the same page. Let's land that and get a new string freeze date from Release Management.

Comment 23

[Erin Lancaster [:elan]]

+1. We've deferred all non-critical string changes. This one, we just really need to have. Please uplift accordingly and we don't take this kind of uplift lightly. With this landing, we're string frozen for Find My Device for 2.0. Thank you.

Comment 24

[Ryan VanderMeulen [:RyanVM]]

v2.0: https://github.com/mozilla-b2g/gaia/commit/7bb5daea0f37d4371e9daa08045d45fef3b30344

Had to rebase around bug 1025193, FWIW.

Comment 25

[Ryan VanderMeulen [:RyanVM]]

This is failing Gaia unit tests.
https://tbpl.mozilla.org/php/getParsedLog.php?id=42299840&tree=Mozilla-Aurora

I have to run now, but I will revert this when I get home if the failures aren't addressed in the mean time.

Comment 26

[Guilherme Gonçalves [:ggp]]

I think it should be fine to revert for now, and I expect the issue to be gone if we uplift bug 1022992 before this one.

The test is failing because this patch doesn't expect apps/settings/js/findmydevice.js to depend on navigator.mozL10n.get, but that dependence was removed by bug 1022992.

Comment 27

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Reverted from v2.0 in https://github.com/mozilla-b2g/gaia/commit/9d2f7bd16a8dc0c74c97c5a40d2f0731f3dfff4b

Comment 28

[Théo Chevalier]

This backed out strings post string freeze. Can we get an estimate on when this can be landed again?

Comment 29

[Ryan VanderMeulen [:RyanVM]]

Bug 1022992 doesn't cherry-pick cleanly on its own and it's too late for me to look at it today. It's very possible that it will cherry-pick OK once I get caught up on the 30+ other patches currently backlogged on v2.0 uplift from my recent PTO. I'll try again tomorrow morning EDT.

Comment 30

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: PR against v2.0

Comment 31

[Arthur Chen [:arthurcc][inactive after 6/30]]

https://tbpl.mozilla.org/?tree=Gaia-Try&rev=498ae3a6e1161c2dffdf7ccd6ad8c5ad5ac46568

2.0: b75153f6e7352c0280512b0ac83aea083da939a0

Comment 32

[Erin Lancaster [:elan]]

Arthur, are we good to request approval for aurora uplift?

Comment 33

[Erin Lancaster [:elan]]

nevermind!