Closed
Bug 1000203
Opened 10 years ago
Closed 10 years ago
Incorrect value checked for domains length in readFromXML
Categories
(MailNews Core :: Account Manager, defect)
MailNews Core
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 31.0
People
(Reporter: mkaply, Assigned: mkaply)
Details
Attachments
(1 file)
|
1.03 KB,
patch
|
BenB
:
review+
|
Details | Diff | Splinter Review |
The check here: http://mxr.mozilla.org/comm-central/source/mailnews/base/prefs/content/accountcreation/readFromXML.js#53 is incorrect. It should be: if (d.domains.length == 0)
Isn't it referencing the 'domain' in the loop just above and should be included inside it?
|
Assignee | |
Comment 2•10 years ago
|
||
No, it's supposed to be checking if it got any domains at all as a result of the for loop. I already checked with Ben who wrote the code and he agreed.
|
||
Updated•10 years ago
|
Attachment #8411226 -
Flags: review?(ben.bucksch) → review+
|
||
Comment 4•10 years ago
|
||
https://hg.mozilla.org/comm-central/rev/97318005efc0
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 31.0
You need to log in
before you can comment on or make changes to this bug.
Description
•