100021 - Want "Advanced properties..." as default format/properties label

Status: VERIFIED FIXED

(SeaMonkey :: Composer, defect)

Description

[[e-mail]]

Currently when Mozilla can't figure out which tag it is settings properties for,
it just displays " Properties" i.e. with a leading space. Moreover, when it
decides there are no properties then it uses string manipulation to remove the
space, which IMHO isn't a localizable way of doing it. I propose that when
Mozilla isn't using a specific tag then it should display "Advanced
properties..." as the label.
Index: editor.js
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/composer/content/editor.js,v
retrieving revision 1.105
diff -u -r1.105 editor.js
--- editor.js   2001/09/10 21:50:12     1.105
+++ editor.js   2001/09/17 08:51:20
@@ -1590,7 +1590,7 @@
   if (!menuItem) return null;

   var element;
-  var menuStr = GetString("ObjectProperties");
+  var menuStr = GetString("AdvancedProperties");
   var name;

   if (IsEditingRenderedHTML())
@@ -1638,15 +1638,13 @@
         }
         break;
     }
-    menuStr = menuStr.replace(/%obj%/,objStr);
+    if (objStr)
+      menuStr = GetString("ObjectProperties").replace(/%obj%/,objStr);
   }
   else
   {
     // We show generic "Properties" string, but disable menu item
     menuItem.setAttribute("disabled","true");
-    // Replace placeholder with "", then remaining space on left side
-    menuStr = menuStr.replace(/%obj%/,"").replace(/^\s+/, "");
-
   }
   menuItem.setAttribute("label", menuStr);
   menuItem.setAttribute("accesskey",GetString("ObjectPropertiesAccessKey"));

Index: editor.properties
===================================================================
RCS file: /cvsroot/mozilla/editor/ui/composer/locale/en-US/editor.properties,v
retrieving revision 1.56
diff -u -r1.56 editor.properties
--- editor.properties   2001/08/18 00:10:37     1.56
+++ editor.properties   2001/09/17 08:54:30
@@ -118,7 +118,8 @@
 Tag=Tag
 # LOCALIZATION NOTE (ObjectProperties):Don't translate "%obj%" it will be repla
ced with one of above object nouns
 ObjectProperties=%obj% Properties...
-# LOCALIZATION NOTE This character must be in the above string and not confict
with other accesskeys in Format menu
+AdvancedProperties=Advanced Properties...
+# LOCALIZATION NOTE This character must be in the above two strings and not con
fict with other accesskeys in Format menu
 ObjectPropertiesAccessKey=o
 # LOCALIZATION NOTE (JoinSelectedCells): This variable should contain the "tabl
ejoincells.accesskey"
 # letter as defined in editorOverlay.dtd

Comment 1

[Kathleen :Brade]

-->cmanske for checkin
r=brade on above fixes

Comment 2

[Charles Manske]

*** Bug 99629 has been marked as a duplicate of this bug. ***

Comment 3

[Charles Manske]

Attachment: Neil's fix as an attachment

Comment 4

[Charles Manske]

Comment on attachment 50592 [details] [diff] [review]
Neil's fix as an attachment

r=brade, cmanske

Comment 5

[Joe Hewitt (gone)]

sr=hewitt

Comment 6

[Charles Manske]

checked in.

Comment 7

[James Baxter]

Verified Advanced Properties is now showing up in 10-01 Trunk build

Comment 8

[Charles Manske]

*** Bug 103187 has been marked as a duplicate of this bug. ***