1000211 - Manifest viewer broken

Status: VERIFIED FIXED

(Marketplace Graveyard :: Reviewer Tools, defect, P1)

Description

[Rob Hudson [:robhudson]]

Sentry URL:

http://sentry.mktmon.services.phx1.mozilla.com/mkt/marketplacefirefoxcom/group/6048/


Aggregate Details:

* First Seen: 19 hours ago
* Last Seen: 1 minute ago
* Number of tracebacks: undefined


Traceback:

Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 114, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "amo/decorators.py", line 80, in wrapper
    return f(request, *args, **kw)
  File "addons/decorators.py", line 32, in wrapper
    return f(request, addon, *args, **kw)
  File "amo/decorators.py", line 128, in wrapper
    response = func(*args, **kw)
  File "mkt/reviewers/views.py", line 788, in app_view_manifest
    for k, v in headers.items()),

Comment 1

[Rob Hudson [:robhudson]]

This is broken in two ways:

1. Packaged apps causes a 500 b/c it tries to call `items()` on a string.
2. Permissions are broken client side during display.

Comment 2

[Rob Hudson [:robhudson]]

https://github.com/mozilla/zamboni/commit/3e41706

Comment 3

[Rob Hudson [:robhudson]]

To verify:

1. Check that clicking "View manifest" works correctly for packaged apps.
2. Check that clicking "View manifest" shows permissions correctly.

Comment 4

[Victor Carciu]

Verified as fixed : http://screencast.com/t/SiN36ckpDkZ