1000312 - jacuzzi script fails during puppet run

Status: RESOLVED FIXED

(Infrastructure & Operations :: RelOps: Puppet, task)

Description

[Dustin J. Mitchell [:dustin] (he/him)]

Wed Apr 23 09:27:45 -0700 2014 Puppet (err): /tools/python27/bin/python2.7 /usr/local/bin/jacuzzi_metadata.py -o /etc/jacuzzi_metadata.json returned 1 instead of one of [0]
Wed Apr 23 09:27:45 -0700 2014 /Stage[main]/Jacuzzi_metadata/Exec[get_jacuzzi_metadata]/returns (err): change from notrun to 0 failed: /tools/python27/bin/python2.7 /usr/local/bin/jacuzzi_metadata.py -o /etc/jacuzzi_metadata.json returned 1 instead of one of [0]

Should this even be running in puppet?  It seems like it should be part of runslave.py or somewhere in between.

Comment 1

[Massimo Gervasini [:massimo]]

Hi Dustin,

we need to run the jacuzzi_metadata.py script before the instance_metadata script to decide where to mount the instance storage space; running it as part of runslave.py would be just too late.

In any case we need to make the script more robust.

Comment 2

[Massimo Gervasini [:massimo]]

Attachment: [puppet] - jacuzzi script fails during puppet run.patch

Hi rail,

this patch updates how urllib2 exceptions are handled.

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 8413810 [details] [diff] [review]
[puppet] - jacuzzi script fails during puppet run.patch

Review of attachment 8413810 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/jacuzzi_metadata/files/jacuzzi_metadata.py
@@ +27,4 @@
>          log.debug("Fetching %s", url)
>          try:
>              return json.load(urllib2.urlopen(url, timeout=1))
> +        except urllib2.URLError as error:

Can you use the old syntax here (except urllib2.URLError, error:) so we don't rely on newer Python.