1000342 - Fix events service tests

Status: RESOLVED FIXED

(Webmaker Graveyard :: Events, defect)

Description

[inactivate account for kate]

They really need to be fixed. We need auth mocks etc.

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

is this still needed? if so, which train?

Comment 2

[Matt Thompson (@OpenMatt :OpenMatt)]

* Gavin: what train should this be on, you think?

Comment 3

[Gavin Suntop [:gvn]]

Possibly this one. I think Kate made some progress here so I'm going to assign to her. Kate, feel free to punt to next sprint if you need to!

Comment 5

[inactivate account for kate]

Attachment: https://github.com/mozilla/webmaker-events-service/pull/81

Comment 6

[Gavin Suntop [:gvn]]

Comment on attachment 8459820 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/81

LGTM other than a few nits and you need to run grunt clean to pass Travis.

I kind of think we should file a ticket to flesh out some of those tests like "should return events from GET /events" to actually look at the response and validate the JSON somewhat instead of just looking at the status code. Seems like you could get a false positive there...

Comment 7

[inactivate account for kate]

Comment on attachment 8459820 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/81

I had to fix up a few more things -- changing the signature in processes, as well as making sure the db could be synced before any tests ran

Comment 8

[inactivate account for kate]

Also I totally agree that more tests need to be written, I will file some tickets about that now

Comment 9

[inactivate account for kate]

Comment on attachment 8459820 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/81

could use a second pair of eyes on this actually

Comment 10

[Chris DeCairos (:cade)]

Comment on attachment 8459820 [details] [review]
https://github.com/mozilla/webmaker-events-service/pull/81

There's a few path problems to fix in /processes

Other than that, this looks fine