Closed Bug 1000461 Opened 9 years ago Closed 9 years ago

Enable triggering memory report via fifo device on OS X

Categories

(Core :: XPCOM, defect)

Product:
Core
Component:
XPCOM
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla31

People

(Reporter: erahm, Assigned: erahm)

References

Details

(Whiteboard: [MemShrink])

Attachments

(1 file)

Enable triggering memory report via fifo device on OS X
9.37 KB, patch
froydnj
: review+
Details | Diff | Splinter Review 
We currently only support triggering memory reports via fifo on Linux/BSD, there's no reason this wouldn't work on OSX as well. This is mostly useful for triggering memory reports on b2g-desktop.

It would be nice to support signals as well, but as OSX does not support real-time signals we don't have a good option (SIGUSR1 and SIGUSR2 seem to be referenced elsewhere in our code base).
Depends on: 1001137
This patch enables the FifoWatcher on OSX and regroups the logic for signal handling and fifo handling to make ifdefing easier. It is dependent on the patch from bug 1001137.
Attachment #8412273 - Flags: review?(nfroyd)
Attachment #8412273 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/4e47286ce9b7
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Blocks: 1015497
You need to log in before you can comment on or make changes to this bug.