1000480 - Don't attempt to send a presence stanza to the MUC if account is disconnected

Status: RESOLVED WORKSFORME

(Chat Core :: XMPP, defect)

Comment 1

[Patrick Cloke [:clokep]]

Are there any error messages or more information you can add here?

Comment 2

[Florian Quèze [:florian]]

My guess is that when the user leaves a MUC, the JS-XMPP code attempts to send to the server a presence stanza indicating that we have left the MUC; which obviously cannot work if the account is already disconnected.

Comment 3

[aleth [:aleth]]

This lacks steps to reproduce. It's not clear what the problem is either (the relevant part of a debug log or any errors/warnings would be helpful).

Comment 4

[Florian Quèze [:florian]]

(In reply to aleth [:aleth] from comment #3)
> This lacks steps to reproduce.

1. Join a MUC with JS-XMPP.
2. Disconnect the XMPP account from the account manager.
3. Leave the MUC from the UI.

Expected result: nothing, as the MUC was already "left" because the account was offline.

Actual result: JS-XMPP attempts (and fails) to send a presence stanza to the server saying we have left the MUC.

Comment 5

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #4)
> Actual result: JS-XMPP attempts (and fails) to send a presence stanza to the
> server saying we have left the MUC.

I can't reproduce this. Where are you seeing this presence stanza being sent?

Comment 6

[Florian Quèze [:florian]]

(In reply to aleth [:aleth] from comment #5)
> (In reply to Florian Quèze [:florian] [:flo] from comment #4)
> > Actual result: JS-XMPP attempts (and fails) to send a presence stanza to the
> > server saying we have left the MUC.
> 
> I can't reproduce this. Where are you seeing this presence stanza being sent?

That was visible in the debug log, and probably also causing a JS error due to the connection/socket being null.

It's quite possible this is WFM several years later, but closing as 'lacks STRs' didn't feel right ;).

Comment 7

[aleth [:aleth]]

(In reply to Florian Quèze [:florian] [:flo] from comment #6)
> It's quite possible this is WFM several years later, but closing as 'lacks
> STRs' didn't feel right ;).

Alright :-)