Closed
Bug 1000482
Opened 11 years ago
Closed 11 years ago
BuildForwardInner in pkixbuild.cpp does not use its stapledOCSPResponse parameter
Categories
(Core :: Security: PSM, defect)
Core
Security: PSM
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: briansmith, Assigned: briansmith)
Details
Attachments
(1 file)
1.99 KB,
patch
|
keeler
:
review+
mmc
:
review+
|
Details | Diff | Splinter Review |
0:28.36 Warning: C4100 in c:\p\firefox\src\security\pkix\lib\pkixbuild.cpp: 'stapledOCSPResponse' : unreferenced formal parameter
It seems I moved the revocation checking from BuildForwardInner to BuildForward but I forgot to remove the stapledOCSPResponse argument from BuildForward inner.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → brian
Target Milestone: --- → mozilla31
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8411367 -
Flags: review?(dkeeler)
Comment 2•11 years ago
|
||
Comment on attachment 8411367 [details] [diff] [review]
remove-unused-stapledOCSPResponse.patch
Review of attachment 8411367 [details] [diff] [review]:
-----------------------------------------------------------------
Keeler's out this week.
Attachment #8411367 -
Flags: review+
![]() |
||
Updated•11 years ago
|
Attachment #8411367 -
Flags: review?(dkeeler) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/617e8978be14
Thanks for the reviews.
Status: NEW → ASSIGNED
Comment 4•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: mozilla31 → mozilla32
You need to log in
before you can comment on or make changes to this bug.
Description
•