Closed Bug 1000482 Opened 5 years ago Closed 5 years ago

BuildForwardInner in pkixbuild.cpp does not use its stapledOCSPResponse parameter

Categories

(Core :: Security: PSM, defect, trivial)

defect
Not set
trivial

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: briansmith, Assigned: briansmith)

Details

Attachments

(1 file)

0:28.36 Warning: C4100 in c:\p\firefox\src\security\pkix\lib\pkixbuild.cpp: 'stapledOCSPResponse' : unreferenced formal parameter

It seems I moved the revocation checking from BuildForwardInner to BuildForward but I forgot to remove the stapledOCSPResponse argument from BuildForward inner.
Assignee: nobody → brian
Target Milestone: --- → mozilla31
Comment on attachment 8411367 [details] [diff] [review]
remove-unused-stapledOCSPResponse.patch

Review of attachment 8411367 [details] [diff] [review]:
-----------------------------------------------------------------

Keeler's out this week.
Attachment #8411367 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/617e8978be14
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: mozilla31 → mozilla32
You need to log in before you can comment on or make changes to this bug.