1000691 - [tarako] remove the "developer menu" check by default so that in the power off menu will not show "enable APZ for Apps"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Joe Cheng [:jcheng] (please needinfo)]

even though APZC is disabled for Tarako but user can still easily turn it on in the (long press power key) power off menu (the very bottom option "enable APZ for apps")

it looks like we just need to remove the "developer menu" check by default
"developer menu" can be found in "Settings -> device information -> more information -> developer -> developer menu"

Comment 1

[[:fabrice] Fabrice Desré]

I think this issue is also on 1.3. If not, we should just uplift the 1.3 fix.

Comment 2

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

QAWanted to see if this is on by default on a user build.

Comment 3

[Pi Wei Cheng [:piwei] (inactive)]

(In reply to Naoki Hirata :nhirata (please use needinfo instead of cc) from comment #2)
> QAWanted to see if this is on by default on a user build.

I can confirm that 'Enable APZ for all conte...' option in Developer menu is NOT checked by default.
However the 'Enable APZ for apps' option is still accessible via long-pressing the power button.

Tested on:
Device: Tarako 1.3T MOZ
BuildID: 20140424014003
Gaia: 706f474230432c8cb01e124aee2c055ec902aa1d
Gecko: 26ef3dded9ff
Version: 28.1
Firmware Version: sp6821a_gonk4.0_user.pac

Comment 4

[Pi Wei Cheng [:piwei] (inactive)]

Actually, after reading bug 994985 I think the build that I tested is NOT an user build. We will re-test this again when an user build is available for us for testing.

Comment 5

[Joe Cheng [:jcheng] (please needinfo)]

triage: 1.3T+ to make sure it gets removed

Comment 6

[Keven Kuo [:kkuo]]

Hi! Evelyn,

Could you or your team member help on this case?
Thanks

--
Keven

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

We need to confirm the build we are really testing against first.

Comment 8

[Evelyn Hung]

Attachment: point to https://github.com/mozilla-b2g/gaia/pull/18777

Comment 9

[Evelyn Hung]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #7)
> We need to confirm the build we are really testing against first.

Whether the build is correct or not, we also need to remove it from Settings app to prevent user enabling it.

Comment 10

[Arthur Chen [:arthurcc][inactive after 6/30]]

I guess we also need to remove APZ from the sleep menu?

Comment 11

[Evelyn Hung]

(In reply to Arthur Chen [:arthurcc] from comment #10)
> I guess we also need to remove APZ from the sleep menu?

As I know, it won't show up in sleep menu if it's a user build. that's why they were verifying a correct build in comment 4.

Comment 12

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8414310 [details] [review]
point to https://github.com/mozilla-b2g/gaia/pull/18777

r=me. Thanks.

Comment 13

[Arthur Chen [:arthurcc][inactive after 6/30]]

1.3t: f772fdb06e4075ee3d8864ae846930c9d5489806

Comment 14

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Verified the fix.  Developer menus is checked off by default and "enable APZ for Apps" is no longer an option by default on the power off menu.

1.3T Environmental Variables:
Device: Tarako 1.3T MOZ
BuildID: 20140501014002
Gaia: d26a776beae0070b0032248a2ce482bbe6321a6d
Gecko: e90f4b655511
Version: 28.1
Firmware Version: sp6821a-Gonk-4.0-4-29