Closed Bug 1000716 Opened 10 years ago Closed 10 years ago

Intermittent markupview/test/browser_markupview_mutation_02.js | Node is flashing

Categories

(DevTools :: Inspector, defect)

Product:
DevTools
Component:
Inspector
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox32 wontfix, firefox33 fixed, firefox34 fixed, firefox-esr24 unaffected, firefox-esr31 wontfix)

Status:
RESOLVED FIXED
Milestone:
Firefox 34
Tracking Flags:
Tracking Status
firefox32 --- wontfix
firefox33 --- fixed
firefox34 --- fixed
firefox-esr24 --- unaffected
firefox-esr31 --- wontfix

People

(Reporter: philor, Assigned: pbro)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

bug1000716-intermittent-browser_markupview_mutation_02.js v1.patch
3.97 KB, patch
miker
: review+
Details | Diff | Splinter Review 
https://tbpl.mozilla.org/php/getParsedLog.php?id=38359075&tree=Fx-Team
Rev5 MacOSX Mountain Lion 10.8 fx-team debug test mochitest-devtools-chrome-2 on 2014-04-23 18:01:12 PDT for push 3c9f46eaf824
slave: talos-mtnlion-r5-065

18:06:15     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_mutation_02.js | Markup-container object for [object XrayWrapper [object HTMLUListElement]] [MarkupContainer for [Front for domnode/conn47.domnode53]]
18:06:15  WARNING -  TEST-UNEXPECTED-FAIL | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_mutation_02.js | Node is flashing
18:06:15     INFO -  Stack trace:
18:06:15     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_mutation_02.js :: assertNodeFlashing :: line 89
18:06:15     INFO -      JS frame :: chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_mutation_02.js :: test< :: line 75
18:06:15     INFO -      JS frame :: resource://gre/modules/Task.jsm :: TaskImpl_run :: line 282
18:06:15     INFO -      JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: Handler.prototype.process :: line 863
18:06:15     INFO -      JS frame :: resource://gre/modules/Promise.jsm -> resource://gre/modules/Promise-backend.js :: this.PromiseWalker.walkerLoop :: line 742
18:06:15     INFO -      native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
18:06:15     INFO -  TEST-INFO | chrome://mochitests/content/browser/browser/devtools/markupview/test/browser_markupview_mutation_02.js | Starting test: Removing an attribute should flash the node
Patrick, this is happening with pretty high frequency. Any chance you could take a look at this soon? :)
Flags: needinfo?(pbrosset)
This test probably started to fail more often with the changes I made to make all tests e10s compatible. One of the steps of the test became async and we're probably hitting a race condition now when checking of the node is flashing in the markup-view.

My plan is to make the flashing permanent when running tests, instead of being hidden by a setTimeout.
Flags: needinfo?(pbrosset)
Pending try build : https://tbpl.mozilla.org/?tree=Try&rev=5eab0205c2ab
Assignee: nobody → pbrosset
Status: NEW → ASSIGNED
Comment on attachment 8470786 [details] [diff] [review]
bug1000716-intermittent-browser_markupview_mutation_02.js v1.patch

The try build seems to show that the intermittent does away with the patch.
Mike, could you review these changes please?
Attachment #8470786 - Flags: review?(mratcliffe)
Attachment #8470786 - Flags: review?(mratcliffe) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/ff4a25841502
Flags: in-testsuite+
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/ff4a25841502
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 34
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: