Closed Bug 1000718 Opened 8 years ago Closed 8 years ago

Add local storage to sccache

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla32

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

No description provided.
This applied directly on top of https://github.com/glandium/sccache/

The one thing this doesn't do is do some cleanup when the cache is using a lot of diskspace. I'll leave that to a followup.
Assignee: nobody → mh+mozilla
Attachment #8411582 - Flags: review?(mshal)
Comment on attachment 8411582 [details] [diff] [review]
Add basic local storage

>+        directory = os.environ.get('SCCACHE_DIR')

SCCACHE_DIR should also be described in a comment in from_environment()

In addition to the lack of cleanup from disk space, there may be performance concerns by putting all the objects into one directory. A simple one or two-level directory hierarchy like what ccache or .git/objects use would probably suffice.
Attachment #8411582 - Flags: review?(mshal) → review+
Attachment #8411583 - Flags: review?(mshal) → review+
(In reply to Michael Shal [:mshal] from comment #3)
> In addition to the lack of cleanup from disk space, there may be performance
> concerns by putting all the objects into one directory. A simple one or
> two-level directory hierarchy like what ccache or .git/objects use would
> probably suffice.

The key comes with a three-level hierarchy already. Ideally, the hierarchy thing would be handled on the storage end.
Attachment #8412197 - Flags: review?(mshal) → review+
Blocks: 1002614
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Blocks: 1004528
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.