Closed Bug 1000741 Opened 6 years ago Closed 6 years ago

Allow mochitest to overwrite fake mediaconstraint on as-needed base

Categories

(Core :: WebRTC: Audio/Video, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(1 file)

Currently the code in head.js of the WebRTC mochitests always over-writes the 'fake' constraint with the global defined value of FAKE_ENABLED from head.js. We should only add this mediaconstraint if the caller has not provided the 'fake' constraint itself already.
Assignee: nobody → drno
Status: NEW → ASSIGNED
Comment on attachment 8411608 [details] [diff] [review]
allow_gum_caller_to_provide_fake_constraint.patch

Looks good to me. Global variable provides a default, but can override per client. Should be very useful!
Attachment #8411608 - Flags: review?(gmealer) → review+
Comment on attachment 8411608 [details] [diff] [review]
allow_gum_caller_to_provide_fake_constraint.patch

Geo requested someone who is familiar with the code to have a look onto this as well.
The idea is to let test cases set the fake constraint on a need base and not depend on the global setting in head.js.
Attachment #8411608 - Flags: review+ → review?(rjesup)
Attachment #8411608 - Flags: review?(rjesup) → review+
Summary: Allow mochitest to overwrite fake mediacnstraint on as-needed base → Allow mochitest to overwrite fake mediaconstraint on as-needed base
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/1bde15156aba
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
You need to log in before you can comment on or make changes to this bug.