1000748 - remove multilocale-clean help in README since it was removed the makefile

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

multilocale.py will pollute gaia source tree, but we have rewritten multilocale.[py|js] in javascript so we should remove this makefile rule.

Comment 1

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Yuren

It seems that the "multilocale-clean" rule is not in Makefile at all. So the original issue is probably invalid now.

However, I discovered that the readme markdown at /locales directory still holds old information regarding "make multilocale-clean" and multilocale.py. According to george, it appears that the two lines "Use make multilocale-clean to clean the working directory after the above." and "See build/multilocale.py --help for other l10n-related tasks ..." may be removed. Shall we remove the lines?

Comment 2

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

set needinfo to myself \o/

Comment 3

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

yes we should remove it since multilocale-clean is no longer there. could you help on this issue?

Comment 4

[John Lu [:mnjul][Please NI or I'll miss]]

roger that.

Comment 5

[John Lu [:mnjul][Please NI or I'll miss]]

Attachment: Patch

Patch is here :)

Comment 6

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Comment on attachment 8428479 [details] [review]
Patch

looks good!

Comment 7

[John Lu [:mnjul][Please NI or I'll miss]]

Master: https://github.com/mozilla-b2g/gaia/commit/fa0d62bf4e34c601b83006607a583358da8c97a1

Comment 8

[helloarvin]

Hi John,

we eagerly need merge this modification to the branch v1.4, please help land it.

Thanks a lot.

Comment 9

[John Lu [:mnjul][Please NI or I'll miss]]

Hi Arvin,

I can help land *this* patch ( https://github.com/mozilla-b2g/gaia/pull/19623 ) for you. However, are you sure you're looking for *this* bug, and not bug 968666 ?
*This* bug involves only removing two lines from readme texts.

Comment 10

[helloarvin]

Hi John,

Thanks for your kindly reminding.

The story background is that 'due to build script issue, I can not apply a patch to modify system manifest.webapp before build', more details please refer comment1 from Evelyn in mozilla bug1003636 (https://bugzilla.mozilla.org/show_bug.cgi?id=1003636). At that time, we were forced to workaround the issue by checking-in affected local changes to repository for emergency.

So, what I really need is *the patch fixed issue of build script issue*, is it bug 968666?

Comment 11

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

for this purpose you can just modify build script for system app[1], please file another bug for it.

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/build/build.js

Comment 12

[Preeti Raghunath(:Preeti)]

Moving to backlog no user impact here.

Comment 13

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

close this bug since john has merged this pr.