Closed Bug 1000880 Opened 6 years ago Closed 6 years ago

Prevent shell.html to be the toplevel document in the mulet, instead, set it as homepage

Categories

(Firefox OS Graveyard :: Runtime, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
2.0 S1 (9may)

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file, 1 obsolete file)

I think the title is quite explicit.
By default, when we build the mulet with bug 961745's patch,
as we pull b2g/app/b2g.js after browser prefs, the toolkit.defaultChromeURI end up being shell.html.
We would like to keep browser.xul in Mulet. And instead, it would be handy to automatically open shell.html as browser homepage.
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → poirot.alex
Comment on attachment 8411796 [details] [diff] [review]
patch

The build system patch introducing MOZ_MULET is about to land,
so we are good to move forward on this patch.

I fixed the defaultChromeURI issue and also pulled some pref we used to have in gaia/Firefox nightly mode, in order to open gaia by default in a tab, with the devtools and tweaks some sessionstore pref to help ensure having gaia on next firefox launches.

Now I'm wondering if we should spawn a dedicated pref.js file just for the mulet?
I imagine there is multiple ways to do that.
  #ifdef MOZ_MULET
  #include mulet.js
  #endif
Or in the build system, where we pull b2g.js, we could pull mulet.js:
https://github.com/ochameau/mozilla-central/blob/3e450f31d500777954ff16d8aa4b0e49d06b7d21/browser/app/Makefile.in#L10-L12
   ifdef MOZ_MULET
   PREF_JS_EXPORTS += $(topsrcdir)/b2g/app/b2g.js
+  PREF_JS_EXPORTS += $(topsrcdir)/b2g/dev/mulet.js (or b2g/app/mulet.js)
   endif
(Note that I would like to pull that code out of browser/, hopefully we can do something from b2g/dev/ build scripts...)
Attachment #8411796 - Flags: review?(21)
Depends on: 1000122
Attached patch patchSplinter Review
Finally, I end up setting shell.html as a homepage in bug 1000122.
Attachment #8411796 - Attachment is obsolete: true
Attachment #8411796 - Flags: review?(21)
Attachment #8415366 - Flags: review?(21)
Comment on attachment 8415366 [details] [diff] [review]
patch

Review of attachment 8415366 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.
Attachment #8415366 - Flags: review?(21) → review+
Keywords: checkin-needed
Blocks: 1000122
No longer depends on: 1000122
https://hg.mozilla.org/mozilla-central/rev/0a2b76387829
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.