Closed Bug 1000936 Opened 7 years ago Closed 7 years ago

[e10s] Buttons on safe browsing warning page don't do anything

Categories

(Toolkit :: Safe Browsing, defect, P1)

x86
macOS
defect

Tracking

()

VERIFIED FIXED
mozilla34
Tracking Status
e10s + ---

People

(Reporter: blassey, Assigned: evilpie)

References

()

Details

Attachments

(1 file)

1) go to https://www.itisatrap.org/firefox/its-a-trap.html
2) try to click on either button "Get me out of here" or "Why was this page blocked?"

nothing happens
I should have noted that this is in a remote tab
Summary: Buttons on safe browsing warning page don't do anything → [e10s] Buttons on safe browsing warning page don't do anything
Assignee: nobody → ally
Priority: -- → P1
Attached patch about-blockedSplinter Review
Seems to me that this already mostly worked. Just the "Get me out of here" button was using content.location = url, which crashed the child. I took that chance and replaced all uses of content.location on that page.
Assignee: ally → evilpies
Status: NEW → ASSIGNED
Attachment #8463880 - Flags: review?(mconley)
Comment on attachment 8463880 [details] [diff] [review]
about-blocked

Review of attachment 8463880 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.js
@@ +2677,5 @@
>        url = url.split("|")[0];
>    } catch(e) {
>      Components.utils.reportError("Couldn't get homepage pref: " + e);
>    }
> +  gBrowser.loadURI(url);

There's a content.location = reportURL; in onAboutBlocked that we should replace as well.
Attachment #8463880 - Flags: review?(mconley) → review+
https://hg.mozilla.org/mozilla-central/rev/8869d490cb13
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla34
Reproduced the initial issue using an old Nightly (2014-04-24), verified that using a Nightly build (34.0a1 and 35.0a1) after 2014-07-30 the issues does not reproduce anymore. Verified on Windows 7 64bit, Ubuntu 14.04 64bit and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.