1000936 - [e10s] Buttons on safe browsing warning page don't do anything

Status: VERIFIED FIXED

(Toolkit :: Safe Browsing, defect, P1)

Description

[Brad Lassey [:blassey] (use needinfo?)]

1) go to https://www.itisatrap.org/firefox/its-a-trap.html
2) try to click on either button "Get me out of here" or "Why was this page blocked?"

nothing happens

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

I should have noted that this is in a remote tab

Comment 2

[Tom Schuster [:evilpie]]

Attachment: about-blocked

Seems to me that this already mostly worked. Just the "Get me out of here" button was using content.location = url, which crashed the child. I took that chance and replaced all uses of content.location on that page.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8463880 [details] [diff] [review]
about-blocked

Review of attachment 8463880 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.js
@@ +2677,5 @@
>        url = url.split("|")[0];
>    } catch(e) {
>      Components.utils.reportError("Couldn't get homepage pref: " + e);
>    }
> +  gBrowser.loadURI(url);

There's a content.location = reportURL; in onAboutBlocked that we should replace as well.

Comment 4

[Tom Schuster [:evilpie]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8869d490cb13

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8869d490cb13

Comment 6

[Bogdan Maris [:bogdan_maris], Release Desktop QA]

Reproduced the initial issue using an old Nightly (2014-04-24), verified that using a Nightly build (34.0a1 and 35.0a1) after 2014-07-30 the issues does not reproduce anymore. Verified on Windows 7 64bit, Ubuntu 14.04 64bit and Mac OS X 10.9.5.