1001033 - Double extension naming issue

Status: UNCONFIRMED

(Toolkit :: Downloads API, defect)

Description

[Damien A.]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:28.0) Gecko/20100101 Firefox/28.0 (Beta/Release)
Build ID: 20140319120302

Steps to reproduce:

Tring to open twice an attachment «archive tar.bz2»


Actual results:

The first time, the file is saved as /tmp/archive.tar.bz2 and my archive manager (file-roller) opens it fine.

The second time, the file is saved as /tmp/archive.tar-1.bz2 to avoid filename conflict.
File-roller is now unable to open it, claiming it doesn't know tar-1 archive format.


Expected results:

The second time, the file should be renamed as archive-1.tar.bz2, so it won't mess with extension.

Or better, if I open it for the seconde time, just open the archive already in /tmp

Comment 1

[Wayne Mery (:wsmwk)]

DL manager component?

Comment 2

[rsx11m]

That's definitely Core code, yes. The problem is that there is an ambiguity where the chain of file extensions ends. So, if a file is named blah.win32.zip you would find blah-1.win32.zip at least equally satisfactory as the currently blah.win32-1.zip generated. However, if you have something like blah-4.29.2014.docx it would be renamed blah-4-1.29.2014.docx instead, thus the modification distorts the date, contrary to the current version of blah-4.29.2014-1.docx.

The file management is keeping the files around in /tmp at least while the document is open (unless set otherwise, they should be cleared when the application is closed). In case a document of message #1 has the same name as the document in e-mail #2, but different content (somebody updated it, etc.), you can't just reuse that copy unless it is coming from the same message (the latter would need to be verified, so that part might be a valid bug).

Comment 3

[Joe Sabash [:JoeS1]]

What rsx11m said :)