Closed Bug 1001113 Opened 10 years ago Closed 10 years ago

TB Perma-fail: test_bug718500.js | test failed (with xpcshell return code: 0) | Unknown chardet: UTF-7

Categories

(MailNews Core :: Internationalization, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 31.0

People

(Reporter: RyanVM, Assigned: hsivonen)

References

Details

(Keywords: intermittent-failure)

Attachments

(2 files)

https://tbpl.mozilla.org/php/getParsedLog.php?id=38426922&tree=Thunderbird-Trunk

Ubuntu VM 12.04 comm-central opt test xpcshell on 2014-04-24 11:41:29 PDT for push 1ed1687e45b3
slave: tst-linux32-spot-202

TEST-INFO | /builds/slave/test/build/xpcshell/tests/intl/uconv/tests/unit/test_bug718500.js | running test ...
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/intl/uconv/tests/unit/test_bug718500.js | test failed (with xpcshell return code: 0), see following log:
>>>>>>>
TEST-INFO | (xpcshell/head.js) | test MAIN run_test pending (1)
TEST-PASS | /builds/slave/test/build/xpcshell/tests/intl/uconv/tests/unit/test_bug718500.js | [verifyList : 197] 10 == 10
TEST-UNEXPECTED-FAIL | /builds/slave/test/build/xpcshell/tests/intl/uconv/tests/unit/test_bug718500.js | Unknown chardet: UTF-7 - See following stack:
JS frame :: /builds/slave/test/build/xpcshell/tests/intl/uconv/tests/unit/test_bug718500.js :: verifyList :: line 194
JS frame :: /builds/slave/test/build/xpcshell/tests/intl/uconv/tests/unit/test_bug718500.js :: run_test :: line 206
JS frame :: /builds/slave/test/build/xpcshell/head.js :: _execute_test :: line 387
JS frame :: -e :: <TOP_LEVEL> :: line 1
native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
TEST-INFO | (xpcshell/head.js) | exiting test
<<<<<<<
Is it possible to disable the test only on Thunderbird? If it is, please do. This test will be removed by bug 943268 anyway.
And reenable the test and add utf-7 family back to the list once nsCharsetConverterManager has been moved to c-c.
(In reply to Masatoshi Kimura [:emk] from comment #2)
> And reenable the test and add utf-7 family back to the list once
> nsCharsetConverterManager has been moved to c-c.

I'd rather move the test to c-c before nsCharsetConverterManager has moved over. Seems like the easiest fix.
FWIW, just about every patch in my queue will break this test once imported to c-c, so the test will serve as a useful reminder to c-c devs to take action every time a converter goes away from m-c. (Import the converter to c-c OR import the contract ID to c-c while actually delegating to m-c classes [e.g. for TIS-620, GB2312 and ISO-8859-9] OR adjusting this test, chasetData.properties and charsetalias.properties to take into account the removal.)
Comment on attachment 8412450 [details] [diff] [review]
Untested c-c patch

mach doesn't support running xpcshell tests from c-c, so I'll leave testing this patch to c-c developers. I'm already doing too much for c-c. I recommend importing the test, though. See the previous comment for the reason.
Comment on attachment 8412450 [details] [diff] [review]
Untested c-c patch

Thanks for the suggestion. This seems to work just fine. I can land it as well if you want.
Attachment #8412450 - Flags: review+
Attachment #8412462 - Flags: review?(VYV03354) → review+
checkin-neede: one patch to inbound, another to c-c. No need to synchronize the two in any particular way.
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/8e78ded52ec3
Assignee: nobody → hsivonen
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4ca96570171c
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 31.0
FYI, there's still one pending run on c-c that's going to hit these failures. I'll ping in the bug if there's still an issue after it should have picked up the fix.
You need to log in before you can comment on or make changes to this bug.