Closed
Bug 1001126
Opened 10 years ago
Closed 10 years ago
Allow AllTraces CC logging other than at shutdown
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: efaust, Assigned: efaust)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
4.04 KB,
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8412125 -
Flags: review?(continuation)
Comment 1•10 years ago
|
||
Comment on attachment 8412125 [details] [diff] [review] Patch Review of attachment 8412125 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for fixing this! ::: xpcom/base/nsCycleCollector.cpp @@ +220,3 @@ > // various cycle collector optimizations to give a fuller picture of > +// the heap. If set to "shutdown", only shutdown logging will be WantAllTraces. > +// default is none. nit: please turn this into a sentence, like "The default is none." or something. @@ +274,5 @@ > } > } > mLogThisThread = threadLogging && processLogging; > + > + const char * allTracesEnv = PR_GetEnv("MOZ_CC_ALL_TRACES"); nit: const char* allTracesEnv @@ +276,5 @@ > mLogThisThread = threadLogging && processLogging; > + > + const char * allTracesEnv = PR_GetEnv("MOZ_CC_ALL_TRACES"); > + if (allTracesEnv) { > + if (!strcmp(allTracesEnv, "all")) nit: please add braces around both branches of this if. You're in Gecko now. ;) @@ +3426,5 @@ > mListener = aManualListener; > aManualListener = nullptr; > if (!mListener && mParams.LogThisCC(isShutdown)) { > nsRefPtr<nsCycleCollectorLogger> logger = new nsCycleCollectorLogger(); > + if (isShutdown && mParams.AllTracesThisCC(isShutdown)) { Remove the "isShutdown &&" here.
Attachment #8412125 -
Flags: review?(continuation) → review+
Comment 2•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c219ba15faed
Assignee: nobody → efaustbmo
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Can you update the documentation at https://developer.mozilla.org/en-US/docs/Mozilla/Performance/GC_and_CC_logs#Generating_GC_and_CC_logs for this change? In particular with what version this changed in.
Flags: needinfo?(efaustbmo)
Comment 5•9 years ago
|
||
Updated. Thanks for pointing out this problem, Kyle.
Flags: needinfo?(continuation)
Keywords: dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•