Closed
Bug 10012
Opened 26 years ago
Closed 26 years ago
Comparing on unsigned long to -1
Categories
(MailNews Core :: Database, defect, P3)
Tracking
(Not tracked)
VERIFIED
FIXED
M9
People
(Reporter: slamm, Assigned: Bienvenu)
Details
http://cvs-mirror.mozilla.org/webtools/bonsai/cvsblame.cgi?file=mozilla/mailnews/db/msgdb/src/nsMsgDatabase.cpp&mark=1665#1655
1665: if (outPos < 0 || outOid.mOid_Id == -1)
I pulled this of the build warnings page,
http://tinderbox.mozilla.org/SeaMonkey/warnings.html#mscott
Assignee | ||
Updated•26 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•26 years ago
|
||
don't know why this would belong to mscott.
Reporter | ||
Comment 2•26 years ago
|
||
That's just where the cvsblame fell because of revision 1.40:
Change m0id_scope to m_0id_id in order to fix the problem
where the list of msg headers was always empty...
David, should you be the owner then?
Updated•26 years ago
|
Assignee: mscott → bienvenu
Status: ASSIGNED → NEW
Comment 3•26 years ago
|
||
re-assigngint to bienvenu this is his puppy...
Assignee | ||
Comment 4•26 years ago
|
||
I've taken it, or at least I meant to. whoops. Taking it for real.
Assignee | ||
Updated•26 years ago
|
Status: NEW → RESOLVED
Closed: 26 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 5•26 years ago
|
||
fixed in nsMsgDatabase.cpp
Reporter | ||
Comment 8•26 years ago
|
||
David, I do not understand your fix. You are casting a negative number to an
unsigned type? How does that work?
Assignee | ||
Comment 9•26 years ago
|
||
It works by fixing the warning. You'll notice in the mork code that whenever -1
gets assigned to the same variable I'm testing, the same cast happens.
Comment 10•25 years ago
|
||
This no longer generates Build warning. Marking this as verified.
Updated•20 years ago
|
Product: MailNews → Core
Updated•17 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•