1001212 - Cannot preinstall a packaged app that has a mini-manifest using a package_path that is a relative path

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Build, defect)

Description

[Jason Smith [:jsmith]]

Build - 4/24/2014 2.0 Open C Build

STR

1. Setup a variant customization that points to a mini-manifest that uses a relative package path
2. Flash the customization

Expected

The customization should successfully flash.

Actual

The build fails.

Console Output


    MOZILLA_OFFICIAL=1 GAIA_DISTRIBUTION_DIR=customization make production
    adb shell stop b2g
    adb shell rm -r /cache/*
    adb shell rm -r /data/b2g/*
    adb shell rm -r /data/local/webapps
    rm failed for /data/local/webapps, No such file or directory
    adb remount
    remount succeeded
    adb shell rm -r /system/b2g/webapps
    adb shell 'if test -d /persist/svoperapps; then rm -r /persist/svoperapps; fi'
    run-js-command gaia/preferences
    run-js-command gaia/webapp-manifests
    run-js-command gaia/keyboard-layouts
    run-js-command gaia/svoperapps
    [svoperapps.js] fetch apps
    [svoperapps.js] downloading manifest: http://mozilla.github.io/qa-testcase-data/webapi/apps/singleasm.manifest
    Exception: TypeError: matched is null
    SvoperappsBuilder.prototype.getOrigin@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/jsmith/Downloads/gaia/build/svoperapps.js:34:5
    mandifestHandler@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/jsmith/Downloads/gaia/build/svoperapps.js:181:1
    downloadJSON/xhr.onreadystatechange@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/jsmith/Downloads/gaia/build/utils-xpc.js:481:9
    processEvents@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/jsmith/Downloads/gaia/build/utils-xpc.js:531:5
    SvoperappsBuilder.prototype.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/jsmith/Downloads/gaia/build/svoperapps.js:316:1
    exports.execute@resource://gre/modules/commonjs/toolkit/loader.js -> file:///home/jsmith/Downloads/gaia/build/svoperapps.js:320:4
    CommonjsRunner.prototype.run@/home/jsmith/Downloads/gaia/build/xpcshell-commonjs.js:69:5
    run@/home/jsmith/Downloads/gaia/build/xpcshell-commonjs.js:84:3
    @-e:1:1
    
    make: *** [svoperapps] Error 3

Comment 1

[Carmen Jimenez Cabezas]

Jason, I've tried the STR in comment#0 but I can't reproduce the problem. 
Did you change the minimanifest? Can you provide a minimanifest that fails?

Comment 2

[Jason Smith [:jsmith]]

(In reply to Carmen Jimenez Cabezas from comment #1)
> Jason, I've tried the STR in comment#0 but I can't reproduce the problem. 
> Did you change the minimanifest? Can you provide a minimanifest that fails?

Sure. It's a modified version of the mini-manifest seen at https://github.com/mozilla/qa-testcase-data/blob/gh-pages/webapi/apps/singleasm.manifest that switches the package_path from absolute to relative:

{
  "version": "1.0",
  "name": "Precompile Single JS Test App",
  "size" : 10000,
  "release_notes": "First v1.0 release",
  "icons": {
    "126": "/qalogo.png"
  },
  "developer": {
    "name": "Mozilla QA",
    "url": "http://jasondanielsmith.wordpress.com/"
  },
  "package_path": "/qa-testcase-data/webapi/apps/singleasm.zip"
}

Comment 3

[Carmen Jimenez Cabezas]

Attachment: Proposed patch v1

Comment 4

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8413781 [details]
Proposed patch v1

Hi Carmen,
I've put two comments on it, please check and set r? again, thanks!

Comment 5

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8413781 [details]
Proposed patch v1

Hi Carmen,
would you update your patch based on my comments on github and set r? to me again?

Comment 6

[Carmen Jimenez Cabezas]

Comment on attachment 8413781 [details]
Proposed patch v1

https://github.com/mozilla-b2g/gaia/pull/18752

Comment 7

[Carmen Jimenez Cabezas]

Attachment: Proposed patch

Comment 8

[Carmen Jimenez Cabezas]

George, I attached the wrong link, sorry!.
I've done the changes you requested, could you take a look again? thanks

Comment 9

[(Inactive after June) George Duan [:gduan] [:喬智]]

Comment on attachment 8415085 [details] [review]
Proposed patch

it looks good to me. r=gduan

Comment 10

[Carmen Jimenez Cabezas]

Travis looks ok. Thanks for the review.
https://github.com/mozilla-b2g/gaia/commit/201a362bc1b75808e52730fcfec367d22856b87b