1001279 - Add support of websites to opt-out of casting videos

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: Screencasting, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: casting-optout v0.1

Apple introduced an attribute that many video sites are using these days:
x-webkit-airplay=allow|deny

See:
https://developer.apple.com/library/safari/documentation/AudioVideo/Conceptual/AirPlayGuide/OptingInorOutofAirPlay/OptingInorOutofAirPlay.html

We might as well support it too.

I need to add a test too.

Comment 1

[Wesley Johnston (:wesj)]

Comment on attachment 8412368 [details] [diff] [review]
casting-optout v0.1

Review of attachment 8412368 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/chrome/content/CastingApps.js
@@ +143,5 @@
>      }
>  
> +    // Allow websites to opt-out using the Apple airplay attribute
> +    // https://developer.apple.com/library/safari/documentation/AudioVideo/Conceptual/AirPlayGuide/OptingInorOutofAirPlay/OptingInorOutofAirPlay.html
> +    if (aElement.getAttribute("x-webkit-airplay") == "deny") {

===

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: casting-optout-tests v0.1

Some simple tests. Green locally.

Comment 3

[Wesley Johnston (:wesj)]

Comment on attachment 8416096 [details] [diff] [review]
casting-optout-tests v0.1

Review of attachment 8416096 [details] [diff] [review]:
-----------------------------------------------------------------

Nice. That was easy :)

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3355a8d31f
remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/c788ef01538a

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/ad3355a8d31f
https://hg.mozilla.org/mozilla-central/rev/c788ef01538a

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 8412368 [details] [diff] [review]
casting-optout v0.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
User impact if declined: Gives websites control over what videos can be cast, which is a feature on Fx31
Testing completed (on m-c, etc.): Working OK and has a test on m-c
Risk to taking this patch (and alternatives if risky): low
String or IDL/UUID changes made by this patch: none

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b3973b49fe6c
https://hg.mozilla.org/releases/mozilla-aurora/rev/71190db0a57f

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

After talking to a few people, we decided that this code is counter to user choice, so we are backing it out until a real need arises.

https://hg.mozilla.org/integration/fx-team/rev/6c2feedbb3d6
https://hg.mozilla.org/releases/mozilla-aurora/rev/e16b9c26e3fa

Comment 9

[Ryan VanderMeulen [:RyanVM]]

(In reply to Mark Finkle (:mfinkle) from comment #8)
> https://hg.mozilla.org/integration/fx-team/rev/6c2feedbb3d6

Trunk backout merged to m-c.
https://hg.mozilla.org/mozilla-central/rev/6c2feedbb3d6