Closed
Bug 1001279
Opened 10 years ago
Closed 10 years ago
Add support of websites to opt-out of casting videos
Categories
(Firefox for Android Graveyard :: Screencasting, defect)
Tracking
(firefox31 wontfix, firefox32 wontfix)
RESOLVED
INVALID
Firefox 32
People
(Reporter: mfinkle, Assigned: mfinkle)
Details
Attachments
(2 files)
1.22 KB,
patch
|
wesj
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
3.43 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
Apple introduced an attribute that many video sites are using these days: x-webkit-airplay=allow|deny See: https://developer.apple.com/library/safari/documentation/AudioVideo/Conceptual/AirPlayGuide/OptingInorOutofAirPlay/OptingInorOutofAirPlay.html We might as well support it too. I need to add a test too.
Assignee | ||
Updated•10 years ago
|
Attachment #8412368 -
Flags: review?(wjohnston)
Comment 1•10 years ago
|
||
Comment on attachment 8412368 [details] [diff] [review] casting-optout v0.1 Review of attachment 8412368 [details] [diff] [review]: ----------------------------------------------------------------- ::: mobile/android/chrome/content/CastingApps.js @@ +143,5 @@ > } > > + // Allow websites to opt-out using the Apple airplay attribute > + // https://developer.apple.com/library/safari/documentation/AudioVideo/Conceptual/AirPlayGuide/OptingInorOutofAirPlay/OptingInorOutofAirPlay.html > + if (aElement.getAttribute("x-webkit-airplay") == "deny") { ===
Attachment #8412368 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 2•10 years ago
|
||
Some simple tests. Green locally.
Assignee: nobody → mark.finkle
Attachment #8416096 -
Flags: review?(wjohnston)
Comment 3•10 years ago
|
||
Comment on attachment 8416096 [details] [diff] [review] casting-optout-tests v0.1 Review of attachment 8416096 [details] [diff] [review]: ----------------------------------------------------------------- Nice. That was easy :)
Attachment #8416096 -
Flags: review?(wjohnston) → review+
Assignee | ||
Comment 4•10 years ago
|
||
remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/ad3355a8d31f remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/c788ef01538a
Comment 5•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ad3355a8d31f https://hg.mozilla.org/mozilla-central/rev/c788ef01538a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 32
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 8412368 [details] [diff] [review] casting-optout v0.1 [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Gives websites control over what videos can be cast, which is a feature on Fx31 Testing completed (on m-c, etc.): Working OK and has a test on m-c Risk to taking this patch (and alternatives if risky): low String or IDL/UUID changes made by this patch: none
Attachment #8412368 -
Flags: approval-mozilla-aurora?
Updated•10 years ago
|
status-firefox31:
--- → affected
status-firefox32:
--- → fixed
Updated•10 years ago
|
Attachment #8412368 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 7•10 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/b3973b49fe6c https://hg.mozilla.org/releases/mozilla-aurora/rev/71190db0a57f
Flags: in-testsuite+
Assignee | ||
Comment 8•10 years ago
|
||
After talking to a few people, we decided that this code is counter to user choice, so we are backing it out until a real need arises. https://hg.mozilla.org/integration/fx-team/rev/6c2feedbb3d6 https://hg.mozilla.org/releases/mozilla-aurora/rev/e16b9c26e3fa
Resolution: FIXED → INVALID
Updated•10 years ago
|
Comment 9•10 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #8) > https://hg.mozilla.org/integration/fx-team/rev/6c2feedbb3d6 Trunk backout merged to m-c. https://hg.mozilla.org/mozilla-central/rev/6c2feedbb3d6
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•