1001343 - Telephony test: add test case of dialing a call from STK

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

MO call could be triggered by dialer and STK. We should have a test to dialing a call from STK.

Comment 1

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to Szu-Yu Chen [:aknow] from comment #0)
> MO call could be triggered by dialer and STK. We should have a test to
> dialing a call from STK.

There's an existing console command 'gsm call' for simulating an incoming call. What we need for this case is a different console command to simulate an outgoing call.

Comment 2

[Ben Hsu [:HoPang]]

Attachment: Part 1: Create dialSTK() (head.js)

In this patch, we cannot specify the modem from which the outgoing call is dialed, though in some cases we might want to manaully select a modem. However, since other APIs may also need to specify which modem to be controlled, I think it's much more appropriate to file another bug to extend those APIs together.

Comment 3

[Ben Hsu [:HoPang]]

Attachment: Part 2: A new testcase. r=aknow

Comment 4

[Ben Hsu [:HoPang]]

Attachment: [external/qemu] pull request 130

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Comment on attachment 8571201 [details] [diff] [review]
Part 1: Create dialSTK() (head.js)

Review of attachment 8571201 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: dom/telephony/test/marionette/head.js
@@ +486,5 @@
>        });
>    }
>  
>    /**
> +   * Simulate a call dialed out by STK directly

Add a period '.' in the end of line.

@@ +500,5 @@
> +    let p2 = emulator.runCmd("gsm dial " + number);
> +
> +    return Promise.all([p1, p2])
> +      .then(result => {
> +        ok(result[0] instanceof TelephonyCall, "check instance");

Before this line

  let call = result[0];
  then use |call| for the following reference of |result[0]|

The code will be more readable.

Comment 6

[Ben Hsu [:HoPang]]

Attachment: Part 1: Create dialSTK() (head.js) (V2). r=aknow

Comment 7

[Edgar Chen [:edgar]]

Comment on attachment 8571221 [details] [review]
[external/qemu] pull request 130

I left some comments on github already, thank you.

Comment 8

[Ben Hsu [:HoPang]]

Attachment: Part 1: Create dialSTK() (head.js) (V3). r=aknow

Console command updated

Comment 9

[Edgar Chen [:edgar]]

Comment on attachment 8571221 [details] [review]
[external/qemu] pull request 130

Looks good.

Comment 10

[Ben Hsu [:HoPang]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=25784213a4e0&exclusion_profile=false

The failed Marionette WebAPI tests are being processed in Bug 1139841.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2091be67caf4
https://hg.mozilla.org/integration/b2g-inbound/rev/d460c6c205e7

Master: https://github.com/mozilla-b2g/platform_external_qemu/commit/8b21ae3a28067fd69fc02271029bb1828e69e795

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2091be67caf4
https://hg.mozilla.org/mozilla-central/rev/d460c6c205e7