Closed Bug 1001343 Opened 9 years ago Closed 8 years ago

Telephony test: add test case of dialing a call from STK

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set
normal

Tracking

(tracking-b2g:backlog, firefox39 fixed)

RESOLVED FIXED
tracking-b2g backlog
Tracking Status
firefox39 --- fixed

People

(Reporter: aknow, Assigned: bhsu)

Details

Attachments

(3 files, 2 obsolete files)

MO call could be triggered by dialer and STK. We should have a test to dialing a call from STK.
(In reply to Szu-Yu Chen [:aknow] from comment #0)
> MO call could be triggered by dialer and STK. We should have a test to
> dialing a call from STK.

There's an existing console command 'gsm call' for simulating an incoming call. What we need for this case is a different console command to simulate an outgoing call.
Assignee: nobody → bhsu
blocking-b2g: --- → backlog
In this patch, we cannot specify the modem from which the outgoing call is dialed, though in some cases we might want to manaully select a modem. However, since other APIs may also need to specify which modem to be controlled, I think it's much more appropriate to file another bug to extend those APIs together.
Attachment #8571201 - Flags: review?(szchen)
Attachment #8571202 - Flags: review?(szchen)
Attachment #8571221 - Flags: review?(echen)
Attachment #8571202 - Flags: review?(szchen) → review+
Comment on attachment 8571201 [details] [diff] [review]
Part 1: Create dialSTK() (head.js)

Review of attachment 8571201 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks.

::: dom/telephony/test/marionette/head.js
@@ +486,5 @@
>        });
>    }
>  
>    /**
> +   * Simulate a call dialed out by STK directly

Add a period '.' in the end of line.

@@ +500,5 @@
> +    let p2 = emulator.runCmd("gsm dial " + number);
> +
> +    return Promise.all([p1, p2])
> +      .then(result => {
> +        ok(result[0] instanceof TelephonyCall, "check instance");

Before this line

  let call = result[0];
  then use |call| for the following reference of |result[0]|

The code will be more readable.
Attachment #8571201 - Flags: review?(szchen) → review+
Attachment #8571201 - Attachment is obsolete: true
Attachment #8571708 - Flags: review+
Attachment #8571202 - Attachment description: Part 2: A new testcase → Part 2: A new testcase. r=aknow
Comment on attachment 8571221 [details] [review]
[external/qemu] pull request 130

I left some comments on github already, thank you.
Attachment #8571221 - Flags: review?(echen)
Attachment #8571221 - Flags: review?(echen)
Console command updated
Attachment #8571708 - Attachment is obsolete: true
Attachment #8574510 - Flags: review+
Comment on attachment 8571221 [details] [review]
[external/qemu] pull request 130

Looks good.
Attachment #8571221 - Flags: review?(echen) → review+
https://treeherder.mozilla.org/#/jobs?repo=try&revision=25784213a4e0&exclusion_profile=false

The failed Marionette WebAPI tests are being processed in Bug 1139841.
Keywords: checkin-needed
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.