Closed
Bug 1001383
Opened 12 years ago
Closed 12 years ago
HTMLMediaElement::UpdateAudioChannelPlayingState() fails to call AudioChannel API because of IsCalleeChrome()
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla32
People
(Reporter: baku, Assigned: baku)
Details
Attachments
(1 file)
|
1.17 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8412551 -
Flags: review?(bzbarsky)
|
Assignee | |
Updated•12 years ago
|
OS: Linux → All
Hardware: x86_64 → All
|
||
Comment 1•12 years ago
|
||
Comment on attachment 8412551 [details] [diff] [review]
callee.patch
Where is the relevant IsCallerChrome check?
Flags: needinfo?(amarchesini)
|
|
Assignee | |
Comment 2•12 years ago
|
||
1. HTMLMediaElement::UpdateAudioChannelPlayingState()
2. mAudioChannelAgent->StartPlaying(&canPlay);
3. CanPlayChanged(canPlay); <- Here.
Flags: needinfo?(amarchesini)
|
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8412551 [details] [diff] [review]
callee.patch
OK. r=me, but it seems like we should either remove that check or clearly document exactly why it's there or something. Followup is ok for figuring that out.
Attachment #8412551 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
|
||
Updated•7 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•