Closed Bug 1001383 Opened 7 years ago Closed 7 years ago

HTMLMediaElement::UpdateAudioChannelPlayingState() fails to call AudioChannel API because of IsCalleeChrome()

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla32

People

(Reporter: baku, Assigned: baku)

Details

Attachments

(1 file)

Attached patch callee.patchSplinter Review
No description provided.
Attachment #8412551 - Flags: review?(bzbarsky)
OS: Linux → All
Hardware: x86_64 → All
Comment on attachment 8412551 [details] [diff] [review]
callee.patch

Where is the relevant IsCallerChrome check?
Flags: needinfo?(amarchesini)
1. HTMLMediaElement::UpdateAudioChannelPlayingState()
2. mAudioChannelAgent->StartPlaying(&canPlay);
3. CanPlayChanged(canPlay); <- Here.
Flags: needinfo?(amarchesini)
Comment on attachment 8412551 [details] [diff] [review]
callee.patch

OK.  r=me, but it seems like we should either remove that check or clearly document exactly why it's there or something.  Followup is ok for figuring that out.
Attachment #8412551 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/8114506aaccb
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla32
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.